From a5735983e274b179b5869a294afd465cf56b13d3 Mon Sep 17 00:00:00 2001 From: James Opstad <13586373+jamesopstad@users.noreply.github.com> Date: Thu, 27 Mar 2025 19:01:38 +0000 Subject: [PATCH 1/3] Remove react-router:override-optimize-deps plugin --- packages/react-router-dev/vite/plugin.ts | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/packages/react-router-dev/vite/plugin.ts b/packages/react-router-dev/vite/plugin.ts index 9f4fb59c1f..e4a6f29204 100644 --- a/packages/react-router-dev/vite/plugin.ts +++ b/packages/react-router-dev/vite/plugin.ts @@ -1445,26 +1445,6 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => { configureServer: undefined, configurePreviewServer: undefined, })), - { - name: "react-router:override-optimize-deps", - config(userConfig) { - // Prevent unnecessary dependency optimization in the child compiler - if ( - ctx.reactRouterConfig.future.unstable_viteEnvironmentApi && - userConfig.environments - ) { - for (const environmentName of Object.keys( - userConfig.environments - )) { - userConfig.environments[environmentName].optimizeDeps = { - noDiscovery: true, - }; - } - } else { - userConfig.optimizeDeps = { noDiscovery: true }; - } - }, - }, ], }); await viteChildCompiler.pluginContainer.buildStart({}); From 4c53113c542d60c2c92a73a880dd1eda83a9ad83 Mon Sep 17 00:00:00 2001 From: Mark Dalgleish Date: Fri, 28 Mar 2025 08:46:54 +1100 Subject: [PATCH 2/3] Add changeset --- .changeset/wicked-birds-suffer.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wicked-birds-suffer.md diff --git a/.changeset/wicked-birds-suffer.md b/.changeset/wicked-birds-suffer.md new file mode 100644 index 0000000000..2650ad9e2c --- /dev/null +++ b/.changeset/wicked-birds-suffer.md @@ -0,0 +1,5 @@ +--- +"@react-router/dev": patch +--- + +When `future.unstable_viteEnvironmentApi` is enabled, fix `depsOptimizer is required in dev mode` errors when custom environment config has been provided From 90e81b0274125030bd4a916872631294cb8bfc98 Mon Sep 17 00:00:00 2001 From: Mark Dalgleish Date: Fri, 28 Mar 2025 09:29:12 +1100 Subject: [PATCH 3/3] Update changeset --- .changeset/wicked-birds-suffer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/wicked-birds-suffer.md b/.changeset/wicked-birds-suffer.md index 2650ad9e2c..a592030d3e 100644 --- a/.changeset/wicked-birds-suffer.md +++ b/.changeset/wicked-birds-suffer.md @@ -2,4 +2,4 @@ "@react-router/dev": patch --- -When `future.unstable_viteEnvironmentApi` is enabled, fix `depsOptimizer is required in dev mode` errors when custom environment config has been provided +Reinstate dependency optimization in the child compiler to fix `depsOptimizer is required in dev mode` errors when using `vite-plugin-cloudflare` and importing Node.js builtins