Switch to mini-create-router-context #6692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That's just Bundlephobia using a naive logic of calculating bundle size. Our builds are actually smaller now: https://unpkg.com/react-router-dom@5.0.0/umd/ And that's just the worst case, un-tree-shook scenario. Michael did a lot of research on this prior to release, so it's simply a false report. Anyways, this looks good to me. We should be able to drop the polyfill with the next major anyways. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked create-router-context because I saw that the package didn't see much activity anymore and had some obvious tweaks to be made.
See also the install-size of RR. and how it's gone way up with 5.0