Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrap route with location arg in location context #9094

Merged
merged 5 commits into from
Sep 12, 2022
Merged

fix: Wrap route with location arg in location context #9094

merged 5 commits into from
Sep 12, 2022

Commits on Aug 5, 2022

  1. Wrap route with location arg in location context 

    In order for the `useLocation` hook to work with the use of the modal
pattern, routes with the locationArg prop are wrapped in a
LocationContext. This is done conditionally in order to ensure
performance in the default case doesn't change.
    John Pangalos committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5dcc570 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge branch 'dev' into johnpangalos/fix-use-location-for-background-… 

    …routes
    @brophdawg11
    brophdawg11 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    61952ea View commit details
    Browse the repository at this point in the history

  2. Update useLocation unit tests

    @brophdawg11
    brophdawg11 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6f0012b View commit details
    Browse the repository at this point in the history

  3. Remove static markup from test for brevity

    @brophdawg11
    brophdawg11 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ca9921d View commit details
    Browse the repository at this point in the history

  4. Back out formatting change to test

    @brophdawg11
    brophdawg11 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    29f273b View commit details
    Browse the repository at this point in the history