Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect relative prop in NavLink for isActive #9451

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: respect relative prop in NavLink for isActive #9451

merged 1 commit into from
Oct 12, 2022

Conversation

manzano78
Copy link
Contributor

Closes #9450

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: 061c308

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks @manzano78! Going to merge this into my branch and get some tests added 👍

@brophdawg11 brophdawg11 changed the base branch from dev to brophdawg11/navlink-relative October 12, 2022 20:50
@brophdawg11 brophdawg11 merged commit 39390dd into remix-run:brophdawg11/navlink-relative Oct 12, 2022
@brophdawg11 brophdawg11 mentioned this pull request Oct 12, 2022
Merged
brophdawg11 added a commit that referenced this pull request Oct 17, 2022
@brophdawg11 @manzano78
fix: respect relative prop in NavLink for isActive (#9453)
35ff025 
* fix: respect relative prop in NavLink for isActive (#9451)

Co-authored-by: Mikaël ANZANO <m.anzano@meetic-corp.com>

* fix: add unit test for NavLink relative=path

* add changeset

Co-authored-by: Mikaël Anzano <mikael.anzano@gmail.com>
Co-authored-by: Mikaël ANZANO <m.anzano@meetic-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manzano78 @brophdawg11