Skip to content

Commit

Permalink
Support custom Vite build.assetsDir option (#8843)
Browse files Browse the repository at this point in the history
Signed-off-by: Eric Chernuka <ericchernuka@gmail.com>
Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com>
  • Loading branch information
ericchernuka and markdalgleish authored Feb 25, 2024
1 parent 0695c43 commit 03c93fe
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/tender-keys-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Support custom Vite `build.assetsDir` option
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@
- emzoumpo
- enbonnet
- eps1lon
- ericchernuka
- esamattis
- evanwinter
- everdimension
Expand Down
7 changes: 6 additions & 1 deletion packages/remix-dev/vite/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,8 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
remixBrowserManifest: RemixManifest;
remixServerManifest: RemixManifest;
}> => {
invariant(viteConfig);

let viteManifest = await loadViteManifest(
getClientBuildDirectory(ctx.remixConfig)
);
Expand Down Expand Up @@ -833,7 +835,10 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {

let fingerprintedValues = { entry, routes: browserRoutes };
let version = getHash(JSON.stringify(fingerprintedValues), 8);
let manifestPath = `assets/manifest-${version}.js`;
let manifestPath = path.posix.join(
viteConfig.build.assetsDir,
`manifest-${version}.js`
);
let url = `${ctx.remixConfig.publicPath}${manifestPath}`;
let nonFingerprintedValues = { url, version };

Expand Down

0 comments on commit 03c93fe

Please sign in to comment.