From 043091af5c18fc4ded27ff7075f172d78a2c56da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= <info@michaeldeboey.be>
Date: Thu, 20 Jul 2023 19:53:18 +0200
Subject: [PATCH] feat(remix-dev)!: remove `browserBuildDirectory` config
 option

---
 .changeset/silver-readers-think.md |  5 +++++
 packages/remix-dev/config.ts       | 28 +---------------------------
 2 files changed, 6 insertions(+), 27 deletions(-)
 create mode 100644 .changeset/silver-readers-think.md

diff --git a/.changeset/silver-readers-think.md b/.changeset/silver-readers-think.md
new file mode 100644
index 00000000000..78786b7568c
--- /dev/null
+++ b/.changeset/silver-readers-think.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": major
+---
+
+Remove `browserBuildDirectory` config option
diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
index af326fe24ba..7d4a6b1fe98 100644
--- a/packages/remix-dev/config.ts
+++ b/packages/remix-dev/config.ts
@@ -100,14 +100,6 @@ export interface AppConfig {
    */
   assetsBuildDirectory?: string;
 
-  /**
-   * The path to the browser build, relative to remix.config.js. Defaults to
-   * "public/build".
-   *
-   * @deprecated Use `{@link AppConfig.assetsBuildDirectory}` instead
-   */
-  browserBuildDirectory?: string;
-
   /**
    * The URL prefix of the browser build with a trailing slash. Defaults to
    * `"/build/"`. This is the path the browser will use to find assets.
@@ -785,14 +777,8 @@ export async function readConfig(
     ? path.resolve(appDirectory, userEntryServerFile)
     : path.resolve(defaultsDirectory, entryServerFile);
 
-  if (appConfig.browserBuildDirectory) {
-    browserBuildDirectoryWarning();
-  }
-
   let assetsBuildDirectory =
-    appConfig.assetsBuildDirectory ||
-    appConfig.browserBuildDirectory ||
-    path.join("public", "build");
+    appConfig.assetsBuildDirectory || path.join("public", "build");
 
   let absoluteAssetsBuildDirectory = path.resolve(
     rootDirectory,
@@ -1018,18 +1004,6 @@ let disjunctionListFormat = new Intl.ListFormat("en", {
   type: "disjunction",
 });
 
-let browserBuildDirectoryWarning = () =>
-  logger.warn(
-    "The `browserBuildDirectory` config option will be removed in v2",
-    {
-      details: [
-        "You can use the `assetsBuildDirectory` config option instead.",
-        "-> https://remix.run/docs/en/v1.15.0/pages/v2#browserbuilddirectory",
-      ],
-      key: "browserBuildDirectoryWarning",
-    }
-  );
-
 let serverBuildDirectoryWarning = () =>
   logger.warn(
     "The `serverBuildDirectory` config option will be removed in v2",