Skip to content

Commit

Permalink
Merge branch 'dev' into test-vite-vanilla-extract-plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
markdalgleish authored Nov 19, 2023
2 parents 198c3f3 + a86ccbe commit ae5f63a
Show file tree
Hide file tree
Showing 121 changed files with 1,629 additions and 678 deletions.
6 changes: 0 additions & 6 deletions .changeset/afraid-suns-yawn.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/brown-panthers-lay.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/clever-months-swim.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/early-trees-walk.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/eight-jeans-float.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/friendly-insects-compete.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/gentle-ghosts-wait.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/green-buses-suffer.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/hungry-tables-hang.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/itchy-rabbits-fly.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/manifest-modulepreload.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/modern-pans-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Ensure code-split JS files in the server build's assets directory aren't cleaned up after Vite build
12 changes: 0 additions & 12 deletions .changeset/nasty-waves-whisper.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/nervous-fans-do.md

This file was deleted.

11 changes: 0 additions & 11 deletions .changeset/ninety-boats-fail.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/proud-otters-cheat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Fix redundant copying of assets from `public` directory in Vite build. This ensures that static assets aren't duplicated in the server build directory. This also fixes an issue where the build would break if `assetsBuildDirectory` was deeply nested within the `public` directory.
5 changes: 0 additions & 5 deletions .changeset/sharp-kids-bake.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/silent-rice-march.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/slow-eyes-joke.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/stabilize-use-blocker.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/tricky-frogs-film.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Emit assets that were only referenced in the server build into the client assets directory in Vite build
5 changes: 0 additions & 5 deletions .changeset/tricky-news-thank.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/two-boxes-dance.md

This file was deleted.

49 changes: 32 additions & 17 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,48 @@ body:
value: |
Thank you for helping to improve Remix!
## The best bug report is a failing test!
## Option 1: Submit a PR with a failing test
The fastest way to get a bug fixed is to add a failing test and send a pull request. **It's usually easy to do with our bug report test template**.
🏆 The most helpful reproduction is to use our _bug report integration test_ template:
1. Click the "Fork" button
2. Open up the file [`integration/bug-report-test.ts`](https://github.com/remix-run/remix/blob/dev/integration/bug-report-test.ts) on your machine
3. Follow the instructions!
1. [Fork `remix-run/remix`](https://github.com/remix-run/remix/fork)
2. Open [`integration/bug-report-test.ts`](https://github.com/remix-run/remix/blob/dev/integration/bug-report-test.ts) in your editor
3. Follow the instructions and submit a pull request with a failing bug report test!
## I'd rather just report the bug
## Option 2: Continue filling out this form
That's fine too! Go ahead and fill out this form.
If you'd rather open a GitHub issue, here are other ways to share a reproduction (ordered from most helpful to least):
- type: input
- 🥇 Link to a [StackBlitz](https://stackblitz.com/?starters=fullstack) environment
- 🥈 Link to a GitHub repository
- 🥉 Description of project including template, `remix.config.js`, `package.json` scripts, etc.
- type: textarea
id: reproduction
attributes:
label: What version of Remix are you using?
label: Reproduction
description: Link to reproduction and steps to reproduce the behavior
placeholder: Go to https://stackblitz.com/edit/... and click the "Submit" button
validations:
required: true
- type: checkboxes
attributes:
label: Are all your remix dependencies & dev-dependencies using the same version?
options:
- label: "Yes"
required: true
- type: textarea
id: system-info
attributes:
label: Steps to Reproduce
description: Steps to reproduce the behavior.
label: System Info
description: Output of `npx envinfo --system --npmPackages '{vite,@remix-run/*}' --binaries --browsers`
render: shell
placeholder: System, Binaries, Browsers
validations:
required: true
- type: dropdown
id: package-manager
attributes:
label: Used Package Manager
description: Select the used package manager
options:
- npm
- yarn
- pnpm
validations:
required: true
- type: textarea
Expand Down
Loading

0 comments on commit ae5f63a

Please sign in to comment.