Dont prefetch server loader when client loader exists

.changeset/heavy-ways-rule.md

@@ -0,0 +1,5 @@
+---
+"@remix-run/react": patch
+---
+
+Don't prefetch server loader data when clientLoader exists

integration/client-data-test.ts

@@ -977,6 +977,48 @@ test.describe("Client Data", () => {
           'not have a server loader (routeId: "routes/parent.child")'
       );
     });
+
+    test("does not prefetch server loader if a client loader is present", async ({
+      page,
+    }) => {
+      appFixture = await createAppFixture(
+        await createTestFixture({
+          files: {
+            ...getFiles({
+              parentClientLoader: true,
+              parentClientLoaderHydrate: false,
+              childClientLoader: false,
+              childClientLoaderHydrate: false,
+            }),
+            "app/routes/_index.tsx": js`
+              import { Link } from '@remix-run/react'
+              export default function Component() {
+                return (
+                  <>
+                    <Link prefetch="render" to="/parent">Go to /parent</Link>
+                    <Link prefetch="render" to="/parent/child">Go to /parent/child</Link>
+                  </>
+                );
+              }
+          `,
+          },
+        })
+      );
+
+      let dataUrls: string[] = [];
+      page.on("request", (request) => {
+        if (request.url().includes("_data")) {
+          dataUrls.push(request.url());
+        }
+      });
+
+      let app = new PlaywrightFixture(appFixture, page);
+      await app.goto("/", true);
+      // Only prefetch child server loader since parent has a `clientLoader`
+      expect(dataUrls).toEqual([
+        expect.stringMatching(/parent\/child\?_data=routes%2Fparent\.child/),
+      ]);
+    });
   });
 
   test.describe("clientAction - critical route module", () => {
@@ -2212,6 +2254,50 @@ test.describe("single fetch", () => {
             'not have a server loader (routeId: "routes/parent.child")'
         );
       });
+
+      test("does not prefetch server loader if a client loader is present", async ({
+        page,
+      }) => {
+        appFixture = await createAppFixture(
+          await createTestFixture({
+            files: {
+              ...getFiles({
+                parentClientLoader: true,
+                parentClientLoaderHydrate: false,
+                childClientLoader: false,
+                childClientLoaderHydrate: false,
+              }),
+              "app/routes/_index.tsx": js`
+                import { Link } from '@remix-run/react'
+                export default function Component() {
+                  return (
+                    <>
+                      <Link prefetch="render" to="/parent">Go to /parent</Link>
+                      <Link prefetch="render" to="/parent/child">Go to /parent/child</Link>
+                    </>
+                  );
+                }
+            `,
+            },
+          })
+        );
+
+        let dataUrls: string[] = [];
+        page.on("request", (request) => {
+          if (request.url().includes(".data")) {
+            dataUrls.push(request.url());
+          }
+        });
+
+        let app = new PlaywrightFixture(appFixture, page);
+        await app.goto("/", true);
+        // Only prefetch child server loader since parent has a `clientLoader`
+        expect(dataUrls).toEqual([
+          expect.stringMatching(
+            /parent\/child\.data\?_routes=routes%2Fparent\.child/
+          ),
+        ]);
+      });
     });
 
     test.describe("clientAction - critical route module", () => {

packages/remix-react/links.ts

@@ -425,7 +425,11 @@ export function getDataLinkHrefs(
   let path = parsePathPatch(page);
   return dedupeHrefs(
     matches
-      .filter((match) => manifest.routes[match.route.id].hasLoader)
+      .filter(
+        (match) =>
+          manifest.routes[match.route.id].hasLoader &&
+          !manifest.routes[match.route.id].hasClientLoader
+      )
       .map((match) => {
         let { pathname, search } = path;
         let searchParams = new URLSearchParams(search);