Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-testing): stablize createRemixStub #7647

Merged
merged 8 commits into from
Oct 12, 2023
Merged

feat(remix-testing): stablize createRemixStub #7647

merged 8 commits into from
Oct 12, 2023

Conversation

kentcdodds
Copy link
Member

The Remix stub is ready to go 👍

I've been using it for quite a while and don't have any feedback other than: "it's annoying that it's unstable_" 😅

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e06ca02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Minor
@remix-run/testing Minor
create-remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kentcdodds
Copy link
Member Author

🤦‍♂️ I should've known this would be harder 😅

@kentcdodds
Copy link
Member Author

Ok, should be good to go now.

@ryanflorence
Copy link
Member

Wrong branch fam

@ryanflorence ryanflorence changed the base branch from main to dev October 11, 2023 18:56
@ryanflorence ryanflorence changed the base branch from dev to main October 11, 2023 19:06
@ryanflorence ryanflorence changed the base branch from main to dev October 11, 2023 19:06
@ryanflorence
Copy link
Member

ryanflorence commented Oct 11, 2023 •
edited
Loading

alright, I made a new create-remix-stub branch, cherry picked the three commits from this PR and force pushed to this PR's branch. When it's all green, let's merge.

Thanks Kent! I hope the next few weeks are EPIC!

@brophdawg11
Copy link
Contributor

Thanks! I'm going to take a pass at some quick docs for this so I'll just push them to this PR and then get it merged 👍

@brophdawg11 brophdawg11 self-assigned this Oct 11, 2023
machour
machour reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

docs/utils/create-remix-stub.md Outdated Show resolved Hide resolved
packages/remix-testing/__tests__/stub-test.tsx Outdated Show resolved Hide resolved
packages/remix-testing/create-remix-stub.tsx Show resolved Hide resolved
brophdawg11 and others added 2 commits October 12, 2023 09:27
@brophdawg11 @machour
Update docs/utils/create-remix-stub.md
e2a1e77 
Co-authored-by: Mehdi Achour <machour@gmail.com>
@brophdawg11 @machour
Update packages/remix-testing/__tests__/stub-test.tsx
e06ca02 
Co-authored-by: Mehdi Achour <machour@gmail.com>
@brophdawg11 brophdawg11 merged commit 2a3ad8c into dev Oct 12, 2023
5 checks passed
@brophdawg11 brophdawg11 deleted the create-remix-stub branch October 12, 2023 13:38
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.1.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey changed the title feat: stablize createRemixStub feat(remix-testing): stablize createRemixStub Oct 15, 2023
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour left review comments

@sergiodxa sergiodxa sergiodxa approved these changes

@ryanflorence ryanflorence ryanflorence approved these changes

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees

@brophdawg11 brophdawg11

Labels
CLA Signed docs package:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kentcdodds @ryanflorence @brophdawg11 @machour @sergiodxa @MichaelDeBoey