-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): handle Vite v5 manifest path #7846
Conversation
Signed-off-by: Marc MacLeod <847542+marbemac@users.noreply.github.com>
Signed-off-by: Marc MacLeod <847542+marbemac@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 965865e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @marbemac, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@marbemac Thanks for the PR! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Vite v5 build output places the
manifest.json
file inside of a.vite
folder (https://main.vitejs.dev/guide/migration#manifest-files-are-now-generated-in-vite-directory-by-default).This PR tweaks the build process to find the correct vite manifest depending on if vite version >= v5 or not.
Manually tested
build
+start
is working OK with theunstable-vite
template, with Vitev4.5
and Vitev5.0.0-beta.14
.