Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): handle Vite v5 manifest path #7846

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

marbemac
Copy link
Contributor

Vite v5 build output places the manifest.json file inside of a .vite folder (https://main.vitejs.dev/guide/migration#manifest-files-are-now-generated-in-vite-directory-by-default).

This PR tweaks the build process to find the correct vite manifest depending on if vite version >= v5 or not.

Manually tested build + start is working OK with the unstable-vite template, with Vite v4.5 and Vite v5.0.0-beta.14.

Signed-off-by: Marc MacLeod <847542+marbemac@users.noreply.github.com>
Signed-off-by: Marc MacLeod <847542+marbemac@users.noreply.github.com>
Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 965865e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 31, 2023

Hi @marbemac,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Signed-off-by: Marc MacLeod <847542+marbemac@users.noreply.github.com>
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 31, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title fix(vite): vite v5 compat feat(remix-dev): support Vite v5 Oct 31, 2023
@pcattori pcattori added the vite label Nov 1, 2023
@markdalgleish markdalgleish changed the title feat(remix-dev): support Vite v5 fix(vite): handle Vite v5 manifest path Nov 2, 2023
@markdalgleish markdalgleish changed the title fix(vite): handle Vite v5 manifest path fix(dev): handle Vite v5 manifest path Nov 2, 2023
@markdalgleish markdalgleish merged commit d1c93a1 into remix-run:dev Nov 2, 2023
9 checks passed
@markdalgleish
Copy link
Member

@marbemac Thanks for the PR!

@marbemac marbemac deleted the mbm/vite-5-compat branch November 2, 2023 14:37
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants