Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): fix LiveReload component nonce prop #8014

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 15, 2023

Closes: #8010

It looks like this was simply missed out in vite version.

Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: c8841d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hi-ogawa hi-ogawa changed the title fix(remix-dev/vite): support nonce prop for LiveReload component fix(remix-dev/vite): fix LiveReload component's nonce prop Nov 15, 2023
@hi-ogawa hi-ogawa marked this pull request as ready for review November 15, 2023 10:59
@hi-ogawa hi-ogawa changed the title fix(remix-dev/vite): fix LiveReload component's nonce prop fix(remix-dev/vite): fix LiveReload component nonce prop Nov 19, 2023
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit 23a6c4c into remix-run:dev Nov 20, 2023
9 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants