Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Vite build.assetsDir option #8843

Merged
merged 5 commits into from
Feb 25, 2024

Commits on Feb 21, 2024

  1. fix: move manifestPath to use vite's assetsDir

    Previously the manifest location was set to the hardcoded path of `assets`, but if a user configures their build to change the `assetsDir` from Vite the result was a file that was still left in the assets folder.
    
    To handle the configuration in Vite, this moves the path generation to utilize Vite's value so that the manifest javascript file is colocated with all other client assets.
    
    Signed-off-by: Eric Chernuka <ericchernuka@gmail.com>
    ericchernuka committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    733e729 View commit details
    Browse the repository at this point in the history
  2. chore: add ericchernuka contribution.yml

    Signed-off-by: Eric Chernuka <ericchernuka@gmail.com>
    ericchernuka committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6333878 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    da74700 View commit details
    Browse the repository at this point in the history
  2. Add changeset

    markdalgleish authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6ea2a38 View commit details
    Browse the repository at this point in the history
  3. Refactor

    markdalgleish committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6b125cb View commit details
    Browse the repository at this point in the history