From 6016ab7f22e7dc59c219a624a9f89f3cfe2dd83a Mon Sep 17 00:00:00 2001 From: Remko Popma Date: Sun, 30 Oct 2022 10:41:25 -0400 Subject: [PATCH] [#648][#1846] fix broken tests --- src/test/java/picocli/TypeConversionTest.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/test/java/picocli/TypeConversionTest.java b/src/test/java/picocli/TypeConversionTest.java index 4de3ccec5..6cd381763 100644 --- a/src/test/java/picocli/TypeConversionTest.java +++ b/src/test/java/picocli/TypeConversionTest.java @@ -488,8 +488,8 @@ public void testCharConverterInvalidError() throws ParseException { public void testCharArrayConverter() { try { final SupportedTypes cli = new SupportedTypes(); - CommandLine.populateCommand(new SupportedTypes(), "-charArray", "abcd"); - assertEquals(new char[]{'a', 'b', 'c', 'd'}, cli.charArrayField); + CommandLine.populateCommand(cli, "-charArray", "abcd"); + assertArrayEquals(new char[]{'a', 'b', 'c', 'd'}, cli.charArrayField); } catch (Exception exception) { fail("Unexpected exception while converting char[] type: " + exception.getMessage()); } @@ -727,8 +727,7 @@ public int handleParseException(ParameterException ex, String[] args) { //System.out.println(sw); assertTrue(sw.toString().startsWith("picocli.CommandLine$ParameterException: Invalid value for positional parameter at index 0 (): cannot convert 'anything' to int (java.lang.IllegalStateException: bad converter)")); assertTrue(sw.toString().contains(String.format("Caused by: java.lang.IllegalStateException: bad converter%n" + - "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:674)%n" + - "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:672)"))); + "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:"))); } static class TypeConversionExceptionConverter implements ITypeConverter { public Integer convert(String value) throws Exception { @@ -763,8 +762,7 @@ public int handleParseException(ParameterException ex, String[] args) { //System.out.println(sw); assertTrue(sw.toString().startsWith("picocli.CommandLine$ParameterException: Invalid value for positional parameter at index 0 (): I am always thrown")); assertTrue(sw.toString(), sw.toString().contains(String.format("Caused by: picocli.CommandLine$TypeConversionException: I am always thrown%n" + - "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:724)%n" + - "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:722)%n"))); + "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:"))); } static class CustomConverter implements ITypeConverter { public Integer convert(String value) { return Integer.parseInt(value); }