From 8cba6329955e0feb89f037a538086eaad78e320b Mon Sep 17 00:00:00 2001 From: llzen44 <73878466+llzen44@users.noreply.github.com> Date: Sat, 11 Nov 2023 18:06:55 +0100 Subject: [PATCH 1/2] Fix NPE in jline3 Example as ConfigurationPath cannot be null anymore --- .../src/test/java/picocli/shell/jline3/example/Example.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java b/picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java index 7d3ff6d44..69c84683b 100644 --- a/picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java +++ b/picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java @@ -134,7 +134,7 @@ public static void main(String[] args) { try { Supplier workDir = () -> Paths.get(System.getProperty("user.dir")); // set up JLine built-in commands - Builtins builtins = new Builtins(workDir, null, null); + Builtins builtins = new Builtins(workDir, new ConfigurationPath(workDir.get(), workDir.get()), null); builtins.rename(Builtins.Command.TTOP, "top"); builtins.alias("zle", "widget"); builtins.alias("bindkey", "keymap"); From 4d37056120c7186aced9f697b771937228a225c5 Mon Sep 17 00:00:00 2001 From: llzen44 <73878466+llzen44@users.noreply.github.com> Date: Sun, 12 Nov 2023 09:14:04 +0100 Subject: [PATCH 2/2] Update README.md to put in line with corresponding Example.java --- picocli-shell-jline3/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/picocli-shell-jline3/README.md b/picocli-shell-jline3/README.md index f108e61c2..7c221b1a8 100644 --- a/picocli-shell-jline3/README.md +++ b/picocli-shell-jline3/README.md @@ -226,7 +226,7 @@ public class Example { try { Supplier workDir = () -> Paths.get(System.getProperty("user.dir")); // set up JLine built-in commands - Builtins builtins = new Builtins(workDir, null, null); + Builtins builtins = new Builtins(workDir, new ConfigurationPath(workDir.get(), workDir.get()), null); builtins.rename(Builtins.Command.TTOP, "top"); builtins.alias("zle", "widget"); builtins.alias("bindkey", "keymap");