remotion: Fix bad double-seeking behavior
#4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got submitted a video that in the end has only 1 frame with a long duration.
https://discord.com/channels/809501355504959528/919965306171052143/1293534844906897431
It trips up our behavior that waits for 2 new frames before it unblocks the buffer state. With testing on Chrome and Safari, it seems like we are doing better by just not doing this at all and unblock as soon as a new frame is received.
The long-term fix this is to combine it with parseMedia() so that we know all the frames before hand and know when a frame is expected or not.