Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs update] Custom controls - fixes and improvements to sample code & docs #4439

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

ADTC
Copy link
Contributor

@ADTC ADTC commented Oct 30, 2024

  • It's "full control" not "full controls".
  • Improved listing of prerequisites for custom controls outside the player.
  • SVGProps is unused. Removed.
  • Fix initial state of Play/Pause button. It has to update when playerRef changes.
  • TimeDisplay was not exported. Fixed.
  • Name of some components made consistent with the file name.
  • durationInFrames - 1 ?? 0 is invalid since the left hand side is never nullish. Use Math.max instead to enforce >= 0.
  • inFrame and outFrame props are optional in <Player/> so they should be optional in <SeekBar/> as well.
  • VolumeSlider.tsx file name was missing. Fixed.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:44am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:44am
remotion-convert ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:44am

@JonnyBurger
Copy link
Member

Wow thank you! Immensly helpful! 🤗

@JonnyBurger JonnyBurger merged commit b7262fc into remotion-dev:main Oct 30, 2024
13 checks passed
@ADTC ADTC deleted the patch-1 branch October 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants