Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Write test for bad pattern: .md/# #23609

Merged

Conversation

PeterNitsche
Copy link
Contributor

Changes

  • I have added a test checking for invalid links to other markdown files in the markdown documentation.
  • I have generalize the test file for website documentation tests to support all kind of documentations and improved the structuring of the test file.
  • I have removed the test case for relatedOptions. The test case is not related to documentation and is also never executed since relatedOptions is always empty. Since relatedOptions was only referenced in the removed test and has no further meaning, I have removed it from the typings as well.

Context

Closes #23329

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@PeterNitsche PeterNitsche changed the title Write test for bad pattern: .md/# test: Write test for bad pattern: .md/# Jul 29, 2023
viceice
viceice previously approved these changes Jul 29, 2023
@PeterNitsche
Copy link
Contributor Author

@viceice Could you approve the workflow runs please?

@viceice
Copy link
Member

viceice commented Jul 30, 2023

please don't update branch if not necessary, we will use merge queue which squashes all commits

@viceice viceice enabled auto-merge July 30, 2023 06:59
@viceice viceice added this pull request to the merge queue Jul 30, 2023
Merged via the queue into renovatebot:main with commit 8aad74f Jul 30, 2023
@HonkingGoose
Copy link
Collaborator

@PeterNitsche Congratulations on getting your first Renovate contribution merged! 🥳✨

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write test for bad pattern: .md/#
4 participants