Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include newVersion in composer update command #24057

Merged
merged 5 commits into from
Aug 25, 2023
Merged

fix: include newVersion in composer update command #24057

merged 5 commits into from
Aug 25, 2023

Conversation

erikgaal
Copy link
Contributor

@erikgaal erikgaal commented Aug 24, 2023 •
edited
Loading

Changes

  • Use newVersion in composer update command to make sure it only updates to the intended version, and not to a newer version.

Context

Closes #24041

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@erikgaal erikgaal changed the title Include newVersion in Composer update command fix: include newVersion in composer update command Aug 24, 2023
@erikgaal
Copy link
Contributor Author

Also just ran it on my reproduction repository where it now works fine!

@erikgaal erikgaal requested a review from rarkins August 24, 2023 12:51
rarkins
rarkins requested changes Aug 24, 2023
View reviewed changes
lib/modules/manager/composer/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/composer/artifacts.spec.ts Outdated Show resolved Hide resolved
erikgaal and others added 2 commits August 24, 2023 15:00
@erikgaal @rarkins
Apply suggestions from code review
d845c59 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@erikgaal
Update artifacts.spec.ts
5dcb644
@erikgaal erikgaal requested a review from rarkins August 24, 2023 13:08
@rarkins rarkins added this pull request to the merge queue Aug 25, 2023
Merged via the queue into renovatebot:main with commit 8b73104 Aug 25, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.60.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erikgaal erikgaal deleted the patch-composer branch August 25, 2023 12:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikgaal @renovate-release @viceice @rarkins