Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config)!: experimental flags #28187

Closed
wants to merge 256 commits into from
Closed

feat(config)!: experimental flags #28187

wants to merge 256 commits into from

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Mar 30, 2024 •
edited
Loading

Changes

  • Add a new self-hosted conifg option getExperimentalFlag
  • Convert the possible experimental env vars into experimental flags
  • Added validation experimentalFlags
  • Update docs

List of experimentalFlags and their corresponding experimental env vars:

Experimental Env Var Experimental Flag
RENOVATE_X_DISABLE_DOCKER_HUB_TAGS disableDockerHubTags
RENOVATE_X_EXEC_GPID_HANDLE execGpidHandle
RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK noMavenPomCheck
RENOVATE_X_NUGET_DOWNLOAD_NUPKGS nugetDownloadNupkgs
RENOVATE_X_REPO_CACHE_FORCE_LOCAL repoCacheForceLocal
RENOVATE_X_YARN_PROXY yarnProxy
RENOVATE_X_USE_OPENPGP useOpenPgp

Context

Closes: #27879

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh mentioned this pull request Mar 30, 2024
Open
viceice
viceice reviewed Mar 30, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

docs/usage/self-hosted-experimental.md Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Apr 6, 2024
View reviewed changes
docs/usage/self-hosted-experimental-flags.md Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 5 commits April 7, 2024 16:42
@RahulGautamSingh @viceice
Update lib/util/experimental-flags.ts
6ee7872 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh @viceice
Apply suggestions from code review
87ac66b 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh
add tests
15a8720
@RahulGautamSingh
refactor
d0baeca
@RahulGautamSingh
Merge branch 'main' into refactor/experimental-flags
5f3ad4d
HonkingGoose
HonkingGoose suggested changes Apr 8, 2024
View reviewed changes
docs/usage/self-hosted-experimental-flags.md Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title refactor: experimental flags feat: experimental flags Apr 9, 2024
viceice
viceice reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked this as feature, because we need to know when it's released.

The hosted app is using those flags and my own runners too.

@rarkins should we add a migration? 🤔

docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
lib/util/experimental-flags.spec.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @viceice
Update lib/util/experimental-flags.spec.ts
e7326bd 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins
Copy link
Collaborator

rarkins commented Apr 10, 2024

#27879 (comment)

@rarkins
Copy link
Collaborator

rarkins commented Apr 10, 2024

@RahulGautamSingh if this was the first PR, wasn't it meant to be non-breaking so it could be merged first? Or necessary to be breaking?

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Apr 10, 2024 •
edited
Loading

Sorry for the confusion.

This PR doesn't need to be breaking. Initially I thought to merge all related PRs in a single one before mergning in main. Hence I converted some flags in this PR only. These examples made the changes clear so I wanted to keep them till the changes were approved.

If we merge this in main I will remove the converted flags before that, so this PR will be non-breaking.

@RahulGautamSingh RahulGautamSingh changed the title feat(config)!: experimental flags feat(config)!: experimental flags [TESTING] Jun 9, 2024
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review June 10, 2024 17:44
@RahulGautamSingh RahulGautamSingh changed the title feat(config)!: experimental flags [TESTING] feat(config)!: experimental flags Jun 10, 2024
viceice
viceice reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there will be a new docker flag

lib/config/validation.ts Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

there will be a new docker flag

TODO: Add this when renovate:38 gets updated

@rarkins rarkins force-pushed the v38 branch 2 times, most recently from 82b75c6 to ee6c5b6 Compare July 23, 2024 12:50
@viceice viceice force-pushed the v38 branch 2 times, most recently from d66408f to ac9131f Compare July 24, 2024 06:51
@viceice viceice added the breaking Breaking change, requires major version bump label Jul 24, 2024
@viceice viceice added this to the v39 milestone Jul 24, 2024
@RahulGautamSingh
Copy link
Collaborator Author

Drafting this for now, as it has been added to v39 milestone. Will resume work once, v39 branch gets created.

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 24, 2024 22:11
@rarkins rarkins force-pushed the v38 branch 2 times, most recently from 84ad846 to 1d20ad0 Compare July 25, 2024 13:22
@rarkins rarkins deleted the branch renovatebot:v38 July 25, 2024 13:28
@rarkins rarkins closed this Jul 25, 2024
@HonkingGoose HonkingGoose mentioned this pull request Jul 25, 2024
Closed
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice left review comments

@nabeelsaabna nabeelsaabna Awaiting requested review from nabeelsaabna

@secustor secustor Awaiting requested review from secustor

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
v39
Development

Successfully merging this pull request may close these issues.

Convert experimental env into globalOnly experimentalFlags
9 participants
@RahulGautamSingh @rarkins @viceice @secustor @HonkingGoose @nabeelsaabna @takac @AaronMoat @not7cd