Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Template to use [self entityName] for entity name #170

Closed
wants to merge 2 commits into from

Conversation

segiddins
Copy link

No description provided.

@rentzsch
Copy link
Owner

What's the reasoning behind this Pull Request? Just want to bottleneck through +entityName so it's easier to override? If so, what are you doing that you need to override it?

@segiddins
Copy link
Author

It just looks cleaner to me this way.

@tonyarnold
Copy link
Contributor

Honestly, I think mogenerator should not be generating any methods named entityName — there's a private method on NSManagedObject that's causing app store validation to throw warnings. People aren't being rejected for it, but we get a huge amount of noise about the warnings in the MagicalRecord issues tracker.

Wolf, are you open to the idea of coordinating a new name for this method?

@segiddins segiddins closed this Apr 11, 2014
@segiddins segiddins reopened this Apr 11, 2014
@rentzsch rentzsch mentioned this pull request Apr 12, 2014
@rentzsch
Copy link
Owner

@tonyarnold I created an issue just for renaming +entityName: #196.

@segiddins
Copy link
Author

@rentzsch I doubt this is going to be merged at this point; should we just close it?

@segiddins segiddins closed this Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants