Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rook add-on version 1.6.11 #3067

Merged
merged 10 commits into from
Aug 2, 2022
Merged

Add Rook add-on version 1.6.11 #3067

merged 10 commits into from
Aug 2, 2022

Conversation

jala-dx
Copy link
Contributor

@jala-dx jala-dx commented Jun 28, 2022 •
edited by emosbaugh
Loading

What type of PR is this?

type::chore

What this PR does / why we need it:

Adds Rook add-on version 1.6.11.

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

- Adds [Rook add-on](https://kurl.sh/docs/add-ons/rook) version 1.6.11.
- Fixes an issue in [Rook add-on](https://kurl.sh/docs/add-ons/rook) versions 1.5.11 and 1.5.12 that could cause Rook upgrades to fail from versions prior to 1.5.11 due to `auth_allow_insecure_global_id_reclaim` improperly set to `false` for [unpatched Ceph versions](https://docs.ceph.com/en/quincy/security/CVE-2021-20288/).

Does this PR require documentation?

NONE

@jala-dx jala-dx requested a review from a team as a code owner June 28, 2022 19:46
label-checker[bot]
label-checker bot suggested changes Jun 28, 2022
View reviewed changes
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

@jala-dx
Copy link
Contributor Author

jala-dx commented Jun 28, 2022

Upgrade from 1.4.3->1.6.11

@jala-dx jala-dx requested a review from laverya June 28, 2022 19:50
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-6222f82-rook-1.6.11-k8s-docker-2022-06-28T19:59:20Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-540b289-rook-1.6.11-k8s-docker-2022-06-28T22:21:35Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-80ea350-rook-1.6.11-k8s-docker-2022-06-29T18:00:14Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-d30823d-rook-1.6.11-k8s-docker-2022-06-30T22:19:46Z

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-8442291-rook-1.6.11-k8s-docker-2022-07-01T23:42:40Z

jala-dx
jala-dx commented Jul 3, 2022
View reviewed changes
addons/rook/template/base/operator/patches/crds.yaml Outdated
@@ -0,0 +1,136 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new file

jala-dx
jala-dx commented Jul 3, 2022
View reviewed changes
addons/rook/template/base/operator/kustomization.yaml Outdated
@@ -4,3 +4,4 @@ resources:

patchesStrategicMerge:
- patches/deployment-tolerations.yaml
- patches/crds.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in favor of following the documented steps here

https://rook.io/docs/rook/v1.6/ceph-upgrade.html#1-update-common-resources-and-crds

kubectl replace -f crds.yaml
kubectl apply -f crds.yaml

@emosbaugh emosbaugh force-pushed the jalaja/rook-addon-1-6-x branch from 4ea725a to d9029a5 Compare July 26, 2022 20:21
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-ac9c197-rook-1.6.11-k8s-docker-2022-07-26T20:37:11Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-689aefe-rook-1.6.11-k8s-docker-2022-07-26T21:21:31Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-9593d45-rook-1.6.11-k8s-docker-2022-07-26T21:40:35Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-0e0eb5e-rook-1.6.11-k8s-docker-2022-07-26T23:11:20Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-de43ee0-rook-1.6.11-k8s-docker-2022-07-27T01:14:08Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-44f6e6e-rook-1.6.11-k8s-docker-2022-07-27T02:10:41Z

@emosbaugh emosbaugh force-pushed the jalaja/rook-addon-1-6-x branch from d1c9e78 to 1b801d3 Compare July 27, 2022 13:29
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-e95c085-rook-1.6.11-k8s-docker-2022-07-27T13:40:49Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-def4230-rook-1.6.11-k8s-docker-2022-07-27T23:37:49Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-d93534c-rook-1.6.11-k8s-docker-2022-07-28T18:45:47Z

@emosbaugh emosbaugh force-pushed the jalaja/rook-addon-1-6-x branch from e8674fa to 51cb431 Compare August 1, 2022 21:04
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-309bc4c-rook-1.6.11-k8s-docker-2022-08-01T21:15:49Z https://testgrid.kurl.sh/run/pr-3067-309bc4c-rook-1.5.12-k8s-docker-2022-08-01T21:24:42Z https://testgrid.kurl.sh/run/pr-3067-309bc4c-rook-1.5.11-k8s-docker-2022-08-01T21:33:21Z

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-6d26acc-rook-1.6.11-k8s-docker-2022-08-01T22:50:13Z https://testgrid.kurl.sh/run/pr-3067-6d26acc-rook-1.5.12-k8s-docker-2022-08-01T22:59:07Z https://testgrid.kurl.sh/run/pr-3067-6d26acc-rook-1.5.11-k8s-docker-2022-08-01T23:08:26Z

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-609d058-rook-1.6.11-k8s-docker-2022-08-01T23:30:04Z https://testgrid.kurl.sh/run/pr-3067-609d058-rook-1.5.12-k8s-docker-2022-08-01T23:38:45Z https://testgrid.kurl.sh/run/pr-3067-609d058-rook-1.5.11-k8s-docker-2022-08-01T23:47:56Z

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-10ca0ec-rook-1.6.11-k8s-docker-2022-08-02T03:39:49Z https://testgrid.kurl.sh/run/pr-3067-10ca0ec-rook-1.5.12-k8s-docker-2022-08-02T03:48:39Z https://testgrid.kurl.sh/run/pr-3067-10ca0ec-rook-1.5.11-k8s-docker-2022-08-02T03:57:01Z

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-3067-8303812-rook-1.6.11-k8s-docker-2022-08-02T16:12:50Z https://testgrid.kurl.sh/run/pr-3067-8303812-rook-1.5.12-k8s-docker-2022-08-02T16:22:15Z https://testgrid.kurl.sh/run/pr-3067-8303812-rook-1.5.11-k8s-docker-2022-08-02T16:31:25Z

@emosbaugh emosbaugh requested a review from laverya August 2, 2022 17:05
@emosbaugh emosbaugh changed the title Upgrade Rook addon 1.6.11 Add Rook add-on version 1.6.11 Aug 2, 2022
@emosbaugh emosbaugh merged commit 714735c into main Aug 2, 2022
@emosbaugh emosbaugh deleted the jalaja/rook-addon-1-6-x branch August 2, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divolgin divolgin divolgin left review comments

@emosbaugh emosbaugh emosbaugh left review comments

@label-checker label-checker[bot] label-checker[bot] requested changes

@laverya laverya laverya approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jala-dx @emosbaugh @divolgin @laverya