Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-108689] troubleshoot: journald collector #1586

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Jul 24, 2024

@nvanthao nvanthao added the type::feature New feature or request label Jul 24, 2024
@nvanthao nvanthao requested a review from a team as a code owner July 24, 2024 02:49
@nvanthao nvanthao force-pushed the gerard/sc-108689/journald branch from 0780e61 to f453367 Compare July 25, 2024 00:09
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvanthao nvanthao merged commit a57171a into main Jul 28, 2024
27 checks passed
@nvanthao nvanthao deleted the gerard/sc-108689/journald branch July 28, 2024 23:44
@adamancini
Copy link
Member

@nvanthao the docs over at replicatedhq/troubleshoot.sh#569 say that the only supported options for output are "short", "json", or "cat"; but I don't see that validated in the code - is the intent to only support those options (meaning, the other options format are not very useful for Troubleshoot's purposes)?

@nvanthao
Copy link
Member Author

Hi @adamancini, I've updated the doc to remove the misleading supported options. As we are allowing all options in journalctl man page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants