-
Notifications
You must be signed in to change notification settings - Fork 106
Feature mssql #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature mssql #990
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
df0a623
Adds MSSQL collector based on Postgres collector
crdant a38f223
Adds tests for MSSQL based on the tests for Postgres
crdant 65fba58
Adds analyzer
crdant 3cb41f3
Adds MS SQL Server example
crdant ae93c9a
Assures MS SQL tests pass
crdant 0183690
Aligns naming and adds to API
crdant e5be946
Corrects names that weren't updated
crdant ffd1d11
Updates text on sample
crdant 70ded47
Corrects typo
crdant 0d33634
Makes troubleshoot aware of mssql
crdant 715f28f
Uses Hashicorp version library for SQL Server versions
crdant dbc7e5d
Resyncs generated file
crdant 8fd8a54
Cleaning up the workspace.
fcdb895
Updates schemas per PR feedback
crdant 699c314
Merge branch 'feature-mssql' of github.com:crdant/troubleshoot into f…
crdant 50771e1
Merge branch 'main' into feature-mssql
chasehainey 91030bf
Unit Tests.
f51f4b2
fix: address runtime error of nil pointer when concatenating prefligh…
dd04684
chore: chore: update binaries used to build manifests and k8s (#997)
camilamacedo86 11cf3e9
Deduplication for In-Cluster Collectors (#972)
diamonwiggins 4680cd8
refactor: keep support bundle concat logic to be consistent with Pref…
6a0807b
chore: Refactor in cluster analysers (#999)
7c3b5d0
feat: Record summary of execution times of support bundle operations …
c8f883c
chore(deps): bump sigs.k8s.io/controller-runtime from 0.14.2 to 0.14.…
dependabot[bot] 8087953
chore(deps): bump github.com/shirou/gopsutil/v3 from 3.22.12 to 3.23.…
dependabot[bot] 5946e2f
chore: Don't hardcode /bin/bash (#1011)
twz123 4a05b23
chore: Don't print which error in Makefile (#1012)
twz123 ed70320
chore: remove unused code (#1013)
twz123 83c61ba
remove PR label enforcement workflow (#1015)
e3b0c442 8b3c73c
chore(deps): bump go.opentelemetry.io/otel/sdk from 1.11.2 to 1.13.0 …
dependabot[bot] ac53a21
chore(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 (#1017)
dependabot[bot] b135f20
chore(deps): bump github.com/jackc/pgx/v5 from 5.2.0 to 5.3.0 (#1018)
7e3054e
chore(deps): bump github.com/hashicorp/go-getter from 1.6.2 to 1.7.0 …
aea2fd6
feat(support-bundle): print progress in debug non-interactive mode (#…
twz123 41e9601
chore(deps): bump github.com/containerd/containerd from 1.6.12 to 1.6…
dependabot[bot] 86dd407
chore(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 (#1025)
dependabot[bot] 33f3060
chore(deps): bump github.com/containers/image/v5 from 5.24.0 to 5.24.…
dependabot[bot] 70e2b10
Update README to add link for the docs (#1022)
camilamacedo86 a32407a
feat: use klog as the default logging library (#1008)
banjoh aa4620a
chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.1 to 3.23.2…
dependabot[bot] 65e163d
chore(deps): bump go.opentelemetry.io/otel from 1.13.0 to 1.14.0 (#1040)
dependabot[bot] 6a70342
chore(deps): bump github.com/containers/image/v5 from 5.24.1 to 5.24.…
dependabot[bot] c3c01f7
feat: support for rhel 9 variants (rhel, centos, ol, rocky) (#1045)
emosbaugh 316844c
fix: Use namespace from the collector spec for Ceph (#1042)
diamonwiggins 627b33b
chore(deps): bump go.opentelemetry.io/otel/sdk from 1.13.0 to 1.14.0 …
dependabot[bot] bf6afb8
Collector/Analyzer - Subnet Available (#1004)
156f502
chore(deps): bump k8s.io/apimachinery from 0.26.1 to 0.26.2 (#1050)
dependabot[bot] 3c001b1
chore(deps): bump sigs.k8s.io/controller-runtime from 0.14.4 to 0.14.…
dependabot[bot] 244c059
dont run tests on draft PRs (#966)
adamancini 5d06e46
chore(deps): bump k8s.io/klog/v2 from 2.90.0 to 2.90.1 (#1052)
dependabot[bot] 410aa81
chore(deps): bump k8s.io/cli-runtime from 0.26.1 to 0.26.2 (#1049)
dependabot[bot] 944022a
chore(deps): bump k8s.io/apiextensions-apiserver from 0.26.1 to 0.26.…
dependabot[bot] a7b3060
Adds MSSQL collector based on Postgres collector
5225cd8
Merge branch 'main' into feature-mssql
chasehainey 1026685
Missed a merge conflict.
bdf1bb4
More merge conflicts fixed.
e96bf06
Ran go mod tidy.
da886ae
Fixed the function name return.
f9d159f
Merge branch 'main' into feature-mssql
chasehainey 0ecb6c3
Merge branch 'main' into feature-mssql
banjoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| apiVersion: troubleshoot.sh/v1beta2 | ||
| kind: Preflight | ||
| metadata: | ||
| name: sample | ||
| spec: | ||
| collectors: | ||
| - mssql: | ||
| collectorName: mssql | ||
| uri: sqlserver://SA:nac3lle-ch@stise-bOMBay-wag@db.lab.shortrib.net:1433/master | ||
| analyzers: | ||
| - mssql: | ||
| checkName: Must be SQLServer 15.x or later | ||
| collectorName: mssql | ||
| outcomes: | ||
| - fail: | ||
| when: "connected == false" | ||
| message: Cannot connect to SQLServer | ||
| - fail: | ||
| when: "version < 15.x" | ||
| message: The SQLServer must be at least version 15 | ||
| - pass: | ||
| message: The SQLServer connection checks out | ||
| - mssql: | ||
| checkName: Must be SQLServer 14 or earlier | ||
| collectorName: mssql | ||
| outcomes: | ||
| - fail: | ||
| when: "connected == false" | ||
| message: Cannot connect to SQLServer | ||
| - fail: | ||
| when: "version > 14.x" | ||
| message: The SQLServer must be at most version 14 | ||
| - pass: | ||
| message: The SQLServer connection checks out | ||
| - mssql: | ||
| checkName: Must be SQLServer 15.0.2000.1565 | ||
| collectorName: mssql | ||
| outcomes: | ||
| - fail: | ||
| when: "connected == false" | ||
| message: Cannot connect to SQLServer | ||
| - fail: | ||
| when: "version == 15.0.2000.1565" | ||
| message: The SQLServer must be version 15.0.2000.1565 | ||
| - pass: | ||
| message: The SQLServer connection checks out | ||
| - mssql: | ||
| checkName: Must not be SQLServer 15.0.2000.1565 | ||
| collectorName: mssql | ||
| outcomes: | ||
| - fail: | ||
| when: "connected == false" | ||
| message: Cannot connect to SQLServer | ||
| - fail: | ||
| when: "version != 15.0.2000.1565" | ||
| message: The SQLServer must not be version 15.0.2000.1565 | ||
| - pass: | ||
| message: The SQLServer connection checks out | ||
| - mssql: | ||
| checkName: I don't want to connect to your SQL Server | ||
| collectorName: mssql | ||
| outcomes: | ||
| - fail: | ||
| when: "connected == true" | ||
| message: Can connect to your SQL Server | ||
| - fail: | ||
| when: "version != 15.0.2000.1565" | ||
| message: The SQLServer must be version 15.0.2000.1565 | ||
| - pass: | ||
| message: The SQLServer connection checks out | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.