Resolve pytest warnings #127

blast-hardcheese · 2024-11-28T20:13:29Z

Why

Running pytest reports two warnings, it should not.

client depends on NoError, but since by the time pytest is initialized the package has already been imported, pytest raises a warning. Move client (and server, for completeness,) out into a plugin.
tool.pytest.ini_options.env isn't recognized without pytest-env

CI

blast-hardcheese requested a review from a team as a code owner November 28, 2024 20:13

blast-hardcheese requested review from ryantm and removed request for a team November 28, 2024 20:13

blast-hardcheese changed the title ~~Dstewart/resolve pytest warnings~~ Resolve pytest warnings Nov 28, 2024

blast-hardcheese added the chore label Nov 28, 2024

blast-hardcheese force-pushed the dstewart/improve-types branch from 3b01e80 to 6e62f93 Compare November 28, 2024 21:58

blast-hardcheese force-pushed the dstewart/resolve-pytest-warnings branch from 7018fbb to c9bded2 Compare November 28, 2024 21:59

blast-hardcheese added 2 commits November 28, 2024 14:00

Breaking out clientserver fixture module

7f528e3

Adding missing pytest-env plugin

9e658cd

blast-hardcheese force-pushed the dstewart/resolve-pytest-warnings branch from c9bded2 to 9e658cd Compare November 28, 2024 22:00

blast-hardcheese force-pushed the dstewart/improve-types branch from 6e62f93 to ba64db8 Compare November 29, 2024 07:29

masad-frost approved these changes Nov 29, 2024

View reviewed changes

Base automatically changed from dstewart/improve-types to main November 29, 2024 07:39

blast-hardcheese merged commit 7ce86bd into main Nov 29, 2024
3 checks passed

blast-hardcheese deleted the dstewart/resolve-pytest-warnings branch November 29, 2024 07:39