From 031cc3a87b7bf52bf9e81dac92d1368f78c4f8fa Mon Sep 17 00:00:00 2001
From: Alicia Zangger <alicia.zangger@rero.ch>
Date: Wed, 11 Nov 2020 10:21:34 +0100
Subject: [PATCH] circulation: improve labels

* Renames checkin/checkout tab into 'on loan'.
* Renames 'Circulation' menu into 'Checkout/checkin'.
* Improves a placeholder.
* Adds a title to the checkin view.
* Closes rero/rero-ils#1280.

Thoses changes were asked by pilot libraries to make the interface
clearer.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
---
 .../admin/src/app/circulation/checkin/checkin.component.html    | 1 +
 .../admin/src/app/circulation/patron/loan/loan.component.html   | 2 +-
 .../admin/src/app/circulation/patron/main/main.component.html   | 2 +-
 projects/admin/src/app/service/menu.service.ts                  | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/projects/admin/src/app/circulation/checkin/checkin.component.html b/projects/admin/src/app/circulation/checkin/checkin.component.html
index bac3ee5d5..aa63e8851 100644
--- a/projects/admin/src/app/circulation/checkin/checkin.component.html
+++ b/projects/admin/src/app/circulation/checkin/checkin.component.html
@@ -14,6 +14,7 @@
   You should have received a copy of the GNU Affero General Public License
   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
+<h4 translate>Checkout/checkin</h4>
 <section *ngIf="!isLoading; else loading" class="content">
   <div class="row">
     <div class="col col-md-6 mb-4">
diff --git a/projects/admin/src/app/circulation/patron/loan/loan.component.html b/projects/admin/src/app/circulation/patron/loan/loan.component.html
index 0a17b5787..67557c66a 100644
--- a/projects/admin/src/app/circulation/patron/loan/loan.component.html
+++ b/projects/admin/src/app/circulation/patron/loan/loan.component.html
@@ -19,7 +19,7 @@
   <div class="row mb-4">
     <div class="col-12 col-md-6">
       <ng-core-search-input
-        [placeholder]="'Please enter an item barcode.' | translate"
+        [placeholder]="'Checkout/checkin: please enter an item barcode.' | translate"
         [searchText]="searchText"
         (search)="searchValueUpdated($event)"
         [focus]="searchInputFocus"
diff --git a/projects/admin/src/app/circulation/patron/main/main.component.html b/projects/admin/src/app/circulation/patron/main/main.component.html
index 90211bd8b..afc8c92a7 100644
--- a/projects/admin/src/app/circulation/patron/main/main.component.html
+++ b/projects/admin/src/app/circulation/patron/main/main.component.html
@@ -33,7 +33,7 @@
           routerLinkActive="active"
           [routerLinkActiveOptions]="{exact: true}"
           [routerLink]="['/circulation', 'patron', patron.patron.barcode, 'loan']">
-          {{ 'Checkin/Checkout' | translate }}
+          {{ 'On loan' | translate }}
           <span *ngIf="getCirculationStatistics('loans') > 0" class="badge badge-info font-weight-normal">
             {{ getCirculationStatistics('loans') }}
           </span>
diff --git a/projects/admin/src/app/service/menu.service.ts b/projects/admin/src/app/service/menu.service.ts
index 7263be4ad..a1b224957 100644
--- a/projects/admin/src/app/service/menu.service.ts
+++ b/projects/admin/src/app/service/menu.service.ts
@@ -35,7 +35,7 @@ export class MenuService {
         iconCssClass: 'fa fa-users',
         id: 'user-services-menu',
         entries: [{
-          name: this._translateService.instant('Circulation'),
+          name: this._translateService.instant('Checkout/checkin'),
           routerLink: '/circulation',
           iconCssClass: 'fa fa-exchange',
           id: 'circulation-menu'