Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patron: no history returned for deleted items #1139

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Aug 10, 2020

A temporary fix until the US of the patron history is created, to
avoid returning circulation history for deleted items.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@BadrAly BadrAly force-pushed the baa-temp-fix-history branch 2 times, most recently from 6f7dea1 to 8c2856e Compare August 10, 2020 11:17
@BadrAly BadrAly self-assigned this Aug 10, 2020
@BadrAly BadrAly force-pushed the baa-temp-fix-history branch from 8c2856e to 0c6e212 Compare August 10, 2020 11:40
A temporary fix until the US of the patron history is created, to
avoid returning circulation history for deleted items.

* close rero#1137

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-temp-fix-history branch from 0c6e212 to 50f7a91 Compare August 10, 2020 12:32
@BadrAly BadrAly changed the title Patron: no history returned for deleted items patron: no history returned for deleted items Aug 10, 2020
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@BadrAly BadrAly merged commit 6a8ef21 into rero:dev Aug 10, 2020
@BadrAly BadrAly deleted the baa-temp-fix-history branch August 24, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patron profile view raises an error 410 (error 500 displayed) when an item of the history is deleted
4 participants