Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: support non-circulating libraries #2431

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Oct 1, 2021

The transaction locations of a library is selected in the list of pickup
locations of the library. This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/2280
#2367

How to test:

  • make sure there is a library in your organisation with no pickup_location defined.
  • have a patron to place a request on any item of this library to pick it up at anther library.
  • the librarian of this library should be able to send the item to the requested library without problem
  • the librarian of the requested library should be able to receive the item and checkout to the requested patron
  • the item can be returned with no problem at the owning library
  • USE-CASE 2: checkout directly the item at the requested library without requesting it.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added the f: circulation Concerns the circulation interface or backend label Oct 1, 2021
@BadrAly BadrAly added this to the v1.6.0 milestone Oct 1, 2021
@BadrAly BadrAly self-assigned this Oct 1, 2021
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch 5 times, most recently from 782d175 to 161387d Compare October 6, 2021 06:09
@BadrAly BadrAly marked this pull request as ready for review October 7, 2021 06:13
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch from 161387d to 1c7eb72 Compare October 7, 2021 11:25
@BadrAly BadrAly requested review from zannkukai and rerowep October 7, 2021 11:27
@BadrAly BadrAly linked an issue Oct 7, 2021 that may be closed by this pull request
@pronguen
Copy link
Contributor

pronguen commented Oct 11, 2021

  • Item of a library without pick-up location stays in transit
    • This does not happen with item of a library with pick-up location
    • To reproduce
      • Log in in a library without pick-up location (ex: pid:24)
      • Check out an item of this library (ex: pid:3060)
      • Check in this item
      • See that it is in transit but should be on shelf
  • Inconsistency between the transit destination in flash message and in interface
    • To reproduce
      • Log in in a library with pick-up location
      • Check out an item from a library without pick-up location
      • Check in the item
      • See inconsistency
        image
    • Once in transit, we cannot checkin the item to change the status. Nothing happens.
  • Unable to remove the pick-up attribute of location 11 ("Le formulaire contient des erreurs."). This problem does not happen on ils.test.rero.ch.
    https://user-images.githubusercontent.com/8154915/138037567-fa64c80e-6cd7-4ad3-a629-847d2f364c2a.mp4
  • Fix date checkout does not work with item from a library without opening hours. However, these items can be checked-out without using the fixed date feature.
    • To reproduce
      • Find a library without opening hours
      • Take an item from this library
      • Log in from a library with opening hours
      • Do a standard checkout > it works fine
      • Do a fixed date checkout > error

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

circulation: support non-circulating libraries

The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions.

* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes #2367, #2419.
* Adds a non-circulating library to units testing.

@iGormilhit iGormilhit changed the base branch from dev to staging October 12, 2021 05:39
@iGormilhit iGormilhit modified the milestones: v1.6.0, v1.7.0 Oct 14, 2021
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch from b80fbf0 to 7cfd350 Compare October 15, 2021 13:08
@BadrAly BadrAly changed the title circulation: manage non-circulating libraries circulation: support non-circulating libraries Oct 15, 2021
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch from 122a2e9 to 5115a27 Compare October 26, 2021 14:24
@BadrAly BadrAly requested a review from zannkukai October 26, 2021 14:25
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch from 5115a27 to e4d0a6a Compare October 26, 2021 14:42
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch 3 times, most recently from 07bbad9 to 7ecfd52 Compare November 2, 2021 09:53
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours externally.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Fixes situation A of the issue 2419.
* Supports fixed checkout of items of libraries with no opening hours externally.
* Supports checkout of items of libraries with no pickup locations.
* Closes rero#2367.
* Closes rero#2318.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-2280-circ-problems branch from 7ecfd52 to a61071e Compare November 3, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
6 participants