-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circulation: support non-circulating libraries #2431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
782d175
to
161387d
Compare
rerowep
reviewed
Oct 7, 2021
zannkukai
reviewed
Oct 7, 2021
161387d
to
1c7eb72
Compare
|
iGormilhit
suggested changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message proposition:
circulation: support non-circulating libraries
The transaction locations of a library is selected in the list of pickup
locations of the library. This causes issues with libraries that have
no pickup location setted.
With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions.
* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
locations.
* Closes #2367, #2419.
* Adds a non-circulating library to units testing.
zannkukai
reviewed
Oct 11, 2021
zannkukai
approved these changes
Oct 11, 2021
rerowep
approved these changes
Oct 12, 2021
b80fbf0
to
7cfd350
Compare
lauren-d
approved these changes
Oct 19, 2021
933e2de
to
122a2e9
Compare
lauren-d
approved these changes
Oct 26, 2021
zannkukai
requested changes
Oct 26, 2021
122a2e9
to
5115a27
Compare
5115a27
to
e4d0a6a
Compare
zannkukai
approved these changes
Oct 27, 2021
rerowep
requested changes
Oct 28, 2021
e4d0a6a
to
797c0a5
Compare
rerowep
approved these changes
Oct 28, 2021
07bbad9
to
7ecfd52
Compare
The transaction locations of a library is selected in the list of pickup locations of the library. This causes issues with libraries that have no pickup location setted. With this commit, for libraries with no pickup locations the system considers the first library location as transaction location for circulation transactions. These libraries can now checkout items directly from other libraries and once checked-in back they go in_transit. It is still mandatory to setup library hours and notification settings before checkout items. * Upgrades to invenio-circulation v1.0.0a34. * Supports checkout of items of libraries with no opening hours externally. * Fixes problem when in transit flash message was always displaying the pickup library. * Fixes situation A of the issue 2419. * Supports fixed checkout of items of libraries with no opening hours externally. * Supports checkout of items of libraries with no pickup locations. * Closes rero#2367. * Closes rero#2318. * Adds a non-circulating library to units testing. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
7ecfd52
to
a61071e
Compare
iGormilhit
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction locations of a library is selected in the list of pickup
locations of the library. This causes issues with libraries that have
no pickup location setted.
With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/2280
#2367
How to test:
pickup_location
defined.send
the item to the requested library without problemreceive
the item andcheckout
to the requested patroncheckout
directly the item at the requested library withoutrequesting
it.Code review check list