circulation: allow checkout from never open library #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: circulation
PascalRepond
force-pushed
the
rep-no-opening
branch
6 times, most recently
from
f80a166
to
2de3530
Compare
zannkukai
requested changes
Jun 16, 2023
PascalRepond
force-pushed
the
rep-no-opening
branch
4 times, most recently
from
3afdc36
to
9c0c25d
Compare
zannkukai
approved these changes
Jun 19, 2023
PascalRepond
force-pushed
the
rep-no-opening
branch
from
9c0c25d
to
0de3200
Compare
PascalRepond
force-pushed
the
rep-no-opening
branch
from
0de3200
to
d6c44d4
Compare
Garfield-fr
approved these changes
Jun 19, 2023
PO tests
|
PascalRepond
force-pushed
the
rep-no-opening
branch
from
d6c44d4
to
cb24847
Compare
- Fixes infinite loop when checking out an item from library without open days but with open exception dates in the past. - Add an extended validation to libraries to disallow open exception dates without specifying times. - Fixes LibraryNeverOpen error not being passed to monitoring. - Fixes checkout not possible from library without opening hours. - Closes rero#2419. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond
force-pushed
the
rep-no-opening
branch
from
cb24847
to
ed2e065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open days but with open exception dates in the past.
dates without specifying times.
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?