From 487258c6152855f760ff03fbcd3e24861a710956 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Se=CC=81bastien=20De=CC=81le=CC=80ze?=
 <sebastien.deleze@rero.ch>
Date: Tue, 22 Sep 2020 16:35:13 +0200
Subject: [PATCH] documents: fix thumbnail without external URL
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Shows thumbnail if no external URL is set, even if organisation is configured to point to external files.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
---
 sonar/theme/templates/sonar/macros/macro.html | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sonar/theme/templates/sonar/macros/macro.html b/sonar/theme/templates/sonar/macros/macro.html
index 7087f2bd..e13a1534 100644
--- a/sonar/theme/templates/sonar/macros/macro.html
+++ b/sonar/theme/templates/sonar/macros/macro.html
@@ -23,13 +23,11 @@
 <div class="text-center {{ class }}">
   {% set restricted = file | is_file_restricted(record) %}
   {% if not restricted.restricted %}
-  {% if externalUrl %}
-  {% if file.external_url %}
+  {% if externalUrl and file.external_url %}
   <a href="{{ file.external_url }}" target="_blank">
     <img src="/{{ resource_type }}/{{ record.pid }}/files/{{ thumbnail.key }}" class="img-thumbnail img-fluid"
       alt="{{ file_title }}">
   </a>
-  {% endif %}
   {% else %}
   <a href="/{{ resource_type }}/{{ record.pid }}/preview/{{ file.key }}" data-title="{{ file_title }}"
     class="previewLink">
@@ -38,7 +36,7 @@
   </a>
   {% endif %}
   <p class="my-1 small">{{ file_title }}</p>
-  {% if not externalUrl %}
+  {% if not externalUrl or not file.external_url %}
   <p class="m-0">
     <a href="/{{ resource_type }}/{{ record.pid }}/preview/{{ file.key }}" data-title="{{ file_title }}"
       class="previewLink"><i class="fa fa-eye mr-2"></i></a>