From 08433cb6863585eac4356870e8b2c829d8b4550f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=AE=87=E7=A5=A5?= Date: Fri, 27 Sep 2024 16:49:09 +0800 Subject: [PATCH 1/2] fix dataview bindings --- src/Core__DataView.res | 50 +++++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/Core__DataView.res b/src/Core__DataView.res index 83e09368..22c6e9a4 100644 --- a/src/Core__DataView.res +++ b/src/Core__DataView.res @@ -10,28 +10,28 @@ external fromBufferWithRange: (Core__ArrayBuffer.t, ~byteOffset: int, ~length: i @get external byteLength: t => int = "byteLength" @get external byteOffset: t => int = "byteOffset" -@send external getInt8: t => int = "getInt8" -@send external getUint8: t => int = "getUint8" -@send external getInt16: t => int = "getInt16" -@send external getUint16: t => int = "getUint16" -@send external getInt32: t => int = "getInt32" -@send external getUint32: t => int = "getUint32" - -@send external getFloat32: t => float = "getFloat32" -@send external getFloat64: t => float = "getFloat64" - -@send external getBigInt64: t => bigint = "getBigInt64" -@send external getBigUint64: t => bigint = "getBigUint64" - -@send external setInt8: (t, int) => unit = "setInt8" -@send external setUint8: (t, int) => unit = "setUint8" -@send external setInt16: (t, int) => unit = "setInt16" -@send external setUint16: (t, int) => unit = "setUint16" -@send external setInt32: (t, int) => unit = "setInt32" -@send external setUint32: (t, int) => unit = "setUint32" - -@send external setFloat32: (t, float) => unit = "setFloat32" -@send external setFloat64: (t, float) => unit = "setFloat64" - -@send external setBigInt64: (t, bigint) => unit = "setBigInt64" -@send external setBigUint64: (t, bigint) => unit = "setBigUint64" +@send external getInt8: (t, int) => int = "getInt8" +@send external getUint8: (t, int) => int = "getUint8" +@send external getInt16: (t, int) => int = "getInt16" +@send external getUint16: (t, int) => int = "getUint16" +@send external getInt32: (t, int) => int = "getInt32" +@send external getUint32: (t, int) => int = "getUint32" + +@send external getFloat32: (t, int) => float = "getFloat32" +@send external getFloat64: (t, int) => float = "getFloat64" + +@send external getBigInt64: (t, int) => bigint = "getBigInt64" +@send external getBigUint64: (t, int) => bigint = "getBigUint64" + +@send external setInt8: (t, int, int) => unit = "setInt8" +@send external setUint8: (t, int, int) => unit = "setUint8" +@send external setInt16: (t, int, int) => unit = "setInt16" +@send external setUint16: (t, int, int) => unit = "setUint16" +@send external setInt32: (t, int, int) => unit = "setInt32" +@send external setUint32: (t, int, int) => unit = "setUint32" + +@send external setFloat32: (t, int, float) => unit = "setFloat32" +@send external setFloat64: (t, int, float) => unit = "setFloat64" + +@send external setBigInt64: (t, int, bigint) => unit = "setBigInt64" +@send external setBigUint64: (t, int, bigint) => unit = "setBigUint64" From 490eb572be3b1d8a78a5e898a6764db3ba8c2c6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=AE=87=E7=A5=A5?= Date: Tue, 15 Oct 2024 17:52:38 +0800 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4b3d5727..f41e3a15 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ## 1.6.1 - Add `difference`, `intersection`, `union`, `symmetricDifference`, `isSubsetOf`, `isSupersetOf`, `isDisjointFrom`, `toArray` functions to `Set`. https://github.com/rescript-association/rescript-core/pull/247 +- Fix bindings of DataView. https://github.com/rescript-association/rescript-core/pull/246 ## 1.6.0