From 2a8e4f739fc7ea0c7b72ec48868bf2884866fbe4 Mon Sep 17 00:00:00 2001 From: mdimajo Date: Wed, 30 Oct 2024 18:24:32 +0100 Subject: [PATCH] fix: cleanup unneeded secrets + update default slack channel --- .github/workflows/release_library.yml | 9 +-------- .github/workflows/verify_library.yml | 11 ----------- README.md | 12 ++---------- 3 files changed, 3 insertions(+), 29 deletions(-) diff --git a/.github/workflows/release_library.yml b/.github/workflows/release_library.yml index 9dc9ce7..71ba2aa 100644 --- a/.github/workflows/release_library.yml +++ b/.github/workflows/release_library.yml @@ -36,20 +36,13 @@ on: required: false type: boolean SLACK_NOTIFICATION_SECRET: - default: 'SLACK_WEBHOOK_PLATFORM_PROD' + default: 'SLACK_WEBHOOK_PLATFORM_NONPROD' required: false type: string secrets: NPM_PUBLISH_TOKEN: required: true - #Note: Due to some github actions limitations all the slack webhook secrets that could be used by the librairies need to be added here with required: false - SLACK_WEBHOOK_CORE_NON_PROD: - required: false - SLACK_WEBHOOK_PLATFORM_PROD: - required: false - SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD: - required: false #Secret needed when ENABLE_VISUAL_TESTING = true: # - SIDE_CI_APPLICATION_ID # - SIDE_CI_APPLICATION_PRIVATE_KEY diff --git a/.github/workflows/verify_library.yml b/.github/workflows/verify_library.yml index c885b23..7ec3a29 100644 --- a/.github/workflows/verify_library.yml +++ b/.github/workflows/verify_library.yml @@ -59,17 +59,6 @@ on: secrets: NPM_READ_TOKEN: required: true - # Note: Due to some github actions limitations all the slack webhook secrets that could be used by the libraries need to be added here with required: false - SLACK_WEBHOOK_CORE_NON_PROD: - required: false - SLACK_WEBHOOK_PLATFORM_PROD: - required: false - SLACK_WEBHOOK_PLATFORM_NONPROD: - required: false - SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD: - required: false - SLACK_WEBHOOK_UI_WG: - required: false # Secret needed when ENABLE_VISUAL_TESTING = true: # - CI_SERVICE_ACCOUNT # - PERCY_TOKEN diff --git a/README.md b/README.md index e40b37c..2b84af0 100644 --- a/README.md +++ b/README.md @@ -20,17 +20,13 @@ Templates for Side librairies github actions | ENABLE_VISUAL_TESTING | boolean | false | `false` | | IS_MONOREPO | boolean | false | `false` | | ENABLE_SLACK_NOTIFICATION | boolean | true | `false` | -| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_CORE_NON_PROD | `false` | +| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_PLATFORM_NONPROD | `false` | ### Secrets | Secret | Required | | ---------------------- | ---------------------- | | NPM_READ_TOKEN | `true` | -| SLACK_WEBHOOK_CORE_NON_PROD | `false` | -| SLACK_WEBHOOK_PLATFORM_PROD | `false` | -| SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD | `false` | -| SLACK_WEBHOOK_UI_WG | `false` | | CI_SERVICE_ACCOUNT | `false` | @@ -48,17 +44,13 @@ Templates for Side librairies github actions | ENABLE_VISUAL_TESTING | boolean | false | `false` | | IS_MONOREPO | boolean | false | `false` | | ENABLE_SLACK_NOTIFICATION | boolean | true | `false` | -| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_CORE_NON_PROD | `false` | +| SLACK_NOTIFICATION_SECRET | string | SLACK_WEBHOOK_PLATFORM_NONPROD | `false` | ### Secrets | Secret | Required | | ---------------------- | ---------------------- | | NPM_PUBLISH_TOKEN | `true` | -| SLACK_WEBHOOK_CORE_NON_PROD | `false` | -| SLACK_WEBHOOK_PLATFORM_PROD | `false` | -| SLACK_WEBHOOK_PLATFORM_SERVICES_NONPROD | `false` | -| SLACK_WEBHOOK_UI_WG | `false` | | CI_SERVICE_ACCOUNT | `false` | | SIDE_CI_APPLICATION_ID | `false` | | SIDE_CI_APPLICATION_PRIVATE_KEY | `false` |