Skip to content

Commit fe75aff

Browse files
committed
XEE injection security in XML extension. Reported by Man Yue Mo.
1 parent 93fbbc9 commit fe75aff

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

Diff for: build/tmpl/text/changes.txt

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ Changes log
44
===========
55

66
@version-full@ (@release-date@)
7+
- Bugs fixed
8+
- XEE injection security in XML extension.
9+
Reported by Man Yue Mo.
710

811
- 2.3.11 (09/28/2017)
912
- Bugs fixed

Diff for: modules/org.restlet.ext.xml/src/org/restlet/ext/xml/XmlRepresentation.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,10 @@ protected DocumentBuilder getDocumentBuilder() throws IOException {
370370
dbf.setNamespaceAware(isNamespaceAware());
371371
dbf.setValidating(isValidatingDtd());
372372
dbf.setCoalescing(isCoalescing());
373-
dbf.setExpandEntityReferences(isExpandingEntityRefs());
373+
dbf.setExpandEntityReferences(false);
374+
dbf.setFeature("http://xml.org/sax/features/external-parameter-entities",isExpandingEntityRefs());
375+
dbf.setFeature("http://xml.org/sax/features/external-general-entities",isExpandingEntityRefs());
376+
374377
dbf.setIgnoringComments(isIgnoringComments());
375378
dbf.setIgnoringElementContentWhitespace(isIgnoringExtraWhitespaces());
376379

0 commit comments

Comments
 (0)