August 2017 dependency updates #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes updates for eslint to the newest version. There is a [small issue](airbnb/javascript#1488) around how it parses the eslint config, but based on the aforementioned issue, it does not cause an issue with how eslint is run or configured and will be fixed in an upcoming release. Also ran `eslint —fix` through the code which has come a long way.
benbruning
approved these changes
Aug 2, 2017
BlakeGuilloud
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔︎ I've tested in all browsers (IE11, Firefox, Safari, Chrome, and iOS)
What should this PR do?
This includes updates for eslint to the newest version. There is a small issue around how it parses the eslint config, but based on the aforementioned issue, it does not cause an issue with how eslint is run or configured and will be fixed in an upcoming release. Also ran
eslint —fixthrough the code which has come a long way.There will be a RF PR as well that should be assumed to have this PR linked within it.
What is the acceptance criteria?
gulpsuccessfully with no errors.[If there are UI changes, include a before and after screenshot.]