-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set seccomp profiles and grant SAs necessary premissions to run #154
Conversation
794b491
to
143aad0
Compare
c38d957
to
6707633
Compare
So CI was failing because if I set on the AM deployment the
I checked and indeed the AM dockerimage uses |
Looks good to me 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing approval for @simonpasquier to approve this PR.
We should consider releasing as soon as this merges.
I will let Simon who understands this better approve the PR
When running in namespace with Pod Security Standard profile "restricted" we need to set RunAsNonRoot and SeccompProfile to all workloads running on that namespace. Futhermore on OpenShift to run with a SeccompProfile set we need to grant service accounts premisisons to use the SCC nonroot-v2 rhobs#149
For traceability: After talking with @simonpasquier offline we decided to add to the Alertmanager deployment a arbitrary UID in order to solve the issue above [1] and future prof the Alertmanager deployment if in the future we have to add persistent storage. [1] #154 (comment) |
When running in namespace with Pod Security Standard profile "restricted"
we need to set RunAsNonRoot and SeccompProfile to all workloads running
on that namespace. Futhermore on OpenShift to run with a SeccompProfile
set we need to grant service accounts premisisons to use the SCC
nonroot-v2
Fixes #149