feat: upgrade PO to 0.61.0-rhobs1 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
force-pushed
the
feat-upgrade-po-0.61.1
branch
from
e348df8 to
91a724d
Compare
sthaha
force-pushed
the
feat-upgrade-po-0.61.1
branch
from
91a724d to
11f62ba
Compare
Thank you for the pointer. I had noticed it. The issue was that I was modifying only the prometheusrule validating webhook to adapt to the changes to admission-webhook but not the alertmanager-config validating webhook and the service generated by OLM resulted in conflict. I have fixed that now by
|
sthaha
force-pushed
the
feat-upgrade-po-0.61.1
branch
from
11f62ba to
2a692dc
Compare
| name: obo-prometheus-operator-admission-webhook | ||
| namespace: operators | ||
| path: /admission-prometheusrules/validate | ||
| port: 8443 | ||
| failurePolicy: Ignore | ||
| failurePolicy: Fail |
There was a problem hiding this comment.
I wouldn't change the failure policy as part of this PR. 'Fail' means that applying PrometheusRule will be rejected when the admission webhook service is unavailable or unreachable. We haven't found a good solution for this in CMO for instance.
sthaha
commented
Dec 10, 2022
deploy/dependencies/admission-webhook/alertmanager-config-validating-webhook.yaml
Outdated
Show resolved
Hide resolved
sthaha
commented
Dec 10, 2022
deploy/dependencies/admission-webhook/prometheus-rule-validating-webhook.yaml
Outdated
Show resolved
Hide resolved
Admission Webhook Deployment relies on certs injected by OLM, thus this commit removes tls-certificates volume mounts from admission-webhook deployment. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
feat-upgrade-po-0.61.1
branch
from
00b4060 to
af170a3
Compare
simonpasquier
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.