fix: use mebibytes instead of megabytes for resource defaults #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
previously approved these changes
Jan 13, 2023
The MonitoringStack CRD uses megabytes for default resource limits and requests. Everywhere else we use mebibytes. This commit changes the default to mebibytes as well. Fixes: https://issues.redhat.com/browse/MON-2865 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
mon-stack-resource-default-mebi
branch
from
2546f98 to
abbbcae
Compare
simonpasquier
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MonitoringStack CRD uses megabytes for default resource limits and requests. Everywhere else we use mebibytes.
This commit changes the default to mebibytes as well. Fixes: https://issues.redhat.com/browse/MON-2865
Signed-off-by: Jan Fajerski jfajersk@redhat.com