Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update url link to rhobs-handbook.netlify.app #289

Merged
merged 1 commit into from
May 26, 2023

Conversation

slashpai
Copy link
Member

Fixes #287

@slashpai slashpai requested a review from a team as a code owner May 24, 2023 16:42
simonpasquier
simonpasquier previously approved these changes May 24, 2023
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hear from @jan--f and @sthaha

@sthaha
Copy link
Collaborator

sthaha commented May 24, 2023

Thanks @slashpai . I am okay with it.
Just a thought - https://rhobs-handbook.netlify.app/products/observability-operator so that this can be created and left empty for now.

@slashpai
Copy link
Member Author

Thanks @slashpai . I am okay with it. Just a thought - https://rhobs-handbook.netlify.app/products/observability-operator so that this can be created and left empty for now.

ya that looks good to me, shall we create empty page now in handbook for now?

@simonpasquier
Copy link
Contributor

@slashpai yes let's create a minimal page about ObO in the rhobs/handbook repo first.

@slashpai
Copy link
Member Author

@sthaha
Copy link
Collaborator

sthaha commented May 25, 2023

https://deploy-preview-56--rhobs-handbook.netlify.app/products/observabilityoperator/

Thanks a lot 🤗
sorry if this sounds pedantic. Is it possible to have products/observability-operator to match the gh repo name? and for better readability?

Update:
This is possible by renaming ObservabiltyOperator to Observabilty-Operator

@slashpai
Copy link
Member Author

https://deploy-preview-56--rhobs-handbook.netlify.app/products/observabilityoperator/

Thanks a lot 🤗 sorry if this sounds pedantic. Is it possible to have products/observability-operator to match the gh repo name? and for better readability?

Update: This is possible by renaming ObservabiltyOperator to Observabilty-Operator

https://deploy-preview-56--rhobs-handbook.netlify.app/products/observability-operator/ good ? :)

Fixes rhobs#287

Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@slashpai slashpai merged commit de3e98d into rhobs:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to https://observability-operator.rhobs.io/ which doesn't exist
3 participants