feat: add alert rules for mso #94
Conversation
|
@fpetkovski @sthaha PTAL |
slashpai
force-pushed
the
deploy_mso
branch
4 times, most recently
from
21e72e6 to
3221958
Compare
|
This looks good so far. Do we want to monitor additional metrics, e.g. queue depth? |
Ya I will add other rules as well, created initial PR with only one just to get an idea. Also since we are not using jsonnet how do we want to include other alerts like monitoring prometheus-operator? |
|
Yes, that's a good point. We should include PO alerts as well. |
|
@fpetkovski I added couple of alerts as well, PTAL. I can create separate PR for Prometheus Operator |
slashpai
force-pushed
the
deploy_mso
branch
2 times, most recently
from
1535e2f to
33ad012
Compare
Thanks Sunil. I updated with changes, PTAL |
This commit adds initial rule file for monitoring-stack-operator Signed-off-by: Jayapriya Pai janantha@redhat.com
|
@fpetkovski are we good to merge? or anymore change is required :) |
| summary: Monitoring Stack Operator controller - {{ $labels.controller }} reconcilation takes too long to reconcile | ||
| expr: | | ||
| rate(controller_runtime_reconcile_time_seconds_sum{job="monitoring-stack-operator"}[5m]) / | ||
| rate(controller_runtime_reconcile_time_seconds_count{job="monitoring-stack-operator"}[5m]) |
There was a problem hiding this comment.
What is a rate of a count in this case?
There was a problem hiding this comment.
Ah ok so this is the average loop time, makes sense 👍
This commit adds initial rule file for monitoring-stack-operator
Signed-off-by: Jayapriya Pai janantha@redhat.com
Description:
Add alert rules for controller, create service and servicemonitor