Skip to content

Commit

Permalink
feat: add probe and scrapeConfig selectors
Browse files Browse the repository at this point in the history
  • Loading branch information
carlkyrillos authored May 31, 2023
1 parent 5e0f6c3 commit a2f0897
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/developer.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Developer Docs

In order to contribute to this project, make sure you have go 1.18 installed
In order to contribute to this project, make sure you have go 1.20 installed
on your local machine.

## Dependencies
Expand Down
4 changes: 4 additions & 0 deletions pkg/controllers/monitoring/monitoring-stack/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ func newPrometheus(
ServiceMonitorNamespaceSelector: ms.Spec.NamespaceSelector,
PodMonitorSelector: prometheusSelector,
PodMonitorNamespaceSelector: ms.Spec.NamespaceSelector,
ProbeSelector: prometheusSelector,
ProbeNamespaceSelector: ms.Spec.NamespaceSelector,
ScrapeConfigSelector: prometheusSelector,
ScrapeConfigNamespaceSelector: ms.Spec.NamespaceSelector,
Affinity: &corev1.Affinity{
PodAntiAffinity: &corev1.PodAntiAffinity{
RequiredDuringSchedulingIgnoredDuringExecution: []corev1.PodAffinityTerm{
Expand Down
4 changes: 4 additions & 0 deletions test/e2e/monitoring_stack_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,8 @@ const oboManagedFieldsJson = `
},
"f:podMonitorNamespaceSelector": {},
"f:podMonitorSelector": {},
"f:probeNamespaceSelector": {},
"f:probeSelector": {},
"f:remoteWrite": {},
"f:replicas": {},
"f:resources": {},
Expand All @@ -690,6 +692,8 @@ const oboManagedFieldsJson = `
"f:rules": {
"f:alert": {}
},
"f:scrapeConfigNamespaceSelector": {},
"f:scrapeConfigSelector": {},
"f:scrapeInterval": {},
"f:securityContext": {
"f:fsGroup": {},
Expand Down

0 comments on commit a2f0897

Please sign in to comment.