Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on "rails" gem, depend on parts of Rails that swagger-docs uses #172

Open
adamniedzielski opened this issue Oct 17, 2017 · 1 comment

Comments

@adamniedzielski
Copy link

Description

swagger-docs specifies a dependency on rails gem -

spec.add_runtime_dependency "rails", ">= 3"

rails is just an "umbrella gem" that depends on all the components of Ruby on Rails framework - https://github.com/rails/rails/blob/86ca5b254109e64edeb6e142e656b8a8c247cac8/rails.gemspec - ActiveSupport, ActionPack, ActiveRecord, ...

I want to avoid installing actioncable gem in my Rails application. When swagger-docs specifies rails gem as a dependency then actioncable becomes my transitive dependency automatically and there is no way to avoid installing it.

Proposal

Depend only on these parts of Rails that swagger-docs actually uses, for example:

spec.add_runtime_dependency "activerecord", ">= 3"
spec.add_runtime_dependency "activesupport", ">= 3"

I'm happy to make a PR if you accept the change.

@richhollis
Copy link
Owner

richhollis commented Oct 18, 2017

Hi Adam

Open to PR on this - makes sense.

Rich

adamniedzielski added a commit to adamniedzielski/swagger-docs that referenced this issue Nov 3, 2017
snowblink pushed a commit to notonthehighstreet/swagger-docs that referenced this issue Jul 30, 2019
snowblink pushed a commit to notonthehighstreet/swagger-docs that referenced this issue Jul 30, 2019
* Switch to vector badges in README

Because raster makes eyes bleed on retina displays 😎

[skip ci]

* Do not depend on "rails" gem

Closes richhollis#172

* Add Gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants