Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newest version doesn't work 0.25.3 #145

Closed
rhummelmose opened this issue Oct 19, 2023 · 6 comments · Fixed by #146
Closed

Newest version doesn't work 0.25.3 #145

rhummelmose opened this issue Oct 19, 2023 · 6 comments · Fixed by #146

Comments

@rhummelmose
Copy link

Service name no longer corresponds to application name rendering the Helm chart non-functional. It caused 2 of my production setups a few hours of down time.

Please don't do something like this again.............

Caused by commit 867f85b
@rhummelmose
Copy link
Author

@danyworks @daibrahi

@rhummelmose
Copy link
Author

This is how the problem looks when encountered:

➜ kubectl port-forward -n frihedsbrevet-system service/gcloud-sqlproxy :3306   
error: Pod 'gcloud-sqlproxy-6f8787bf8b-5nxjc' does not have a named port 'frihe-ems4pbefh'

@rhummelmose
Copy link
Author

@rimusz

@danyworks
Copy link
Contributor

@rhummelmose sorry for the inconvenience, i will fix it straight away!

danyworks pushed a commit to danyworks/charts that referenced this issue Oct 19, 2023
@daibrahi
gcloud-sqlproxy fix rimusz#145 generate randomstring using sha1sum no…
46785b0 
…t with randAlphaNum
danyworks pushed a commit to danyworks/charts that referenced this issue Oct 19, 2023
@daibrahi
gcloud-sqlproxy fix rimusz#145 update readme
b513cfd
danyworks pushed a commit to danyworks/charts that referenced this issue Oct 19, 2023
@daibrahi
gcloud-sqlproxy fix rimusz#145 bump chart version
faa4743
@danyworks danyworks mentioned this issue Oct 19, 2023
Merged
3 tasks
@danyworks
Copy link
Contributor

@rhummelmose PR is created, it passed all checks, now waiting for @rimusz to merge it

@rhummelmose
Copy link
Author

Awesome. The reason you didn't encounter this problem is because you specify the short instance name explicitly in values?

rimusz pushed a commit that referenced this issue Oct 20, 2023
@danyworks @daibrahi
[gcloud-sqlproxy] fix #145 use sha1sum instead of randAlphaNum (#146)
daa840e 
* fix #143 add randAlphaNum to instanceShortName

* gcloud-sqlproxy bump chart version to 0.25.3 and update readme

* gcloud-sqlproxy fix#143 allow only lowercase in randomString for instanceShortName

* gcloud-sqlproxy fix#143 reduce length

* gcloud-sqlproxy fix#143 update readme

* gcloud-sqlproxy fix #145 generate randomstring using sha1sum not with randAlphaNum

* gcloud-sqlproxy fix #145 update readme

* gcloud-sqlproxy fix #145 bump chart version

* add new line at the end of Chart.yaml

---------

Co-authored-by: daniyal ibrahim <daniyal.ibrahim@capgemini.com>
@tasnyc tasnyc mentioned this issue Nov 2, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gcloud-sqlproxy] fix #145 use sha1sum instead of randAlphaNum danyworks/charts
2 participants
@rhummelmose @danyworks