[gcloud-sqlproxy] fix #143 add suffix using randAlphaNum to instanceShortName #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyworks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need this:
solves the issue #143
the helpers.tpl now defines the instanceShortName using 5 char prefix from the instance name
then a "-", lastly suffixed by 9 chars from lowercased randAlphaNum function to avoid running into the issue of duplicate values for the port names of gcloud-sqlproxy deployment.yaml
Which issue this PR fixes
fixes #143
Special notes for your reviewer:
will quickly finish the rest steps from the checklist below :)
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[gcloud-sqlproxy])