Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack-make from cockpit crashes with v8 9.8 #520

Closed
andreas-schwab opened this issue Mar 1, 2022 · 9 comments
Closed

webpack-make from cockpit crashes with v8 9.8 #520

andreas-schwab opened this issue Mar 1, 2022 · 9 comments

Comments

@andreas-schwab
Copy link

https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:riscv:node/cockpit/standard/riscv64

This is with the upcoming node v18, which uses 9.8.177.9.

NODE_ENV=production SRCDIR=/home/abuild/rpmbuild/BUILD/cockpit-251.3 ./tools/webpack-make -d dist/base1/Makefile.deps -c ./webpack.config.js
NODE_ENV=production SRCDIR=/home/abuild/rpmbuild/BUILD/cockpit-251.3 ./tools/webpack-make -d dist/apps/Makefile.deps -c ./webpack.config.js
NODE_ENV=production SRCDIR=/home/abuild/rpmbuild/BUILD/cockpit-251.3 ./tools/webpack-make -d dist/kdump/Makefile.deps -c ./webpack.config.js
NODE_ENV=production SRCDIR=/home/abuild/rpmbuild/BUILD/cockpit-251.3 ./tools/webpack-make -d dist/metrics/Makefile.deps -c ./webpack.config.js
make[1]: *** [Makefile:9859: dist/base1/manifest.json] Segmentation fault
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:9859: dist/apps/manifest.json] Segmentation fault
make[1]: *** [Makefile:9859: dist/kdump/manifest.json] Segmentation fault
make[1]: *** [Makefile:9859: dist/metrics/manifest.json] Segmentation fault
@luyahan
Copy link
Collaborator

luyahan commented Mar 1, 2022

may be this pr can fix this
nodejs/node#42067

@andreas-schwab
Copy link
Author

I have already added that patch, it doesn't make a difference.

https://build.opensuse.org/package/view_file/home:Andreas_Schwab:riscv:node/nodejs18/riscv.patch

@luyahan
Copy link
Collaborator

luyahan commented Mar 2, 2022 •
edited
Loading

I try to build cockpit
it happens:

[    1s] processing recipe /root/home:Andreas_Schwab:riscv:node/cockpit/cockpit.spec ...
[    1s] unknown keyword in config: repourl:
[    1s] unknown keyword in config: registryurl:
[    1s] running changelog2spec --target rpm --file /root/home:Andreas_Schwab:riscv:node/cockpit/cockpit.spec
[    1s] init_buildsystem --configdir /usr/lib/build/configs --cachedir /var/cache/build --rpmlist /tmp/rpmlist.2b9r2hj4 /root/home:Andreas_Schwab:riscv:node/cockpit/cockpit.spec ...
[    1s] registering binfmt handlers for cross build
[    1s] mount: /proc: Permission denied
[    1s] /usr/lib/build/init_buildsystem: line 628: /proc/sys/vm/mmap_min_addr: Read-only file system
[    1s] unknown keyword in config: repourl:
[    1s] unknown keyword in config: registryurl:
[    1s] mount: /var/tmp/build-root/standard-riscv64/proc: cannot mount none read-only.
[    1s] Could not mount /proc, is this a container with missing capabilities?
[    1s]
[    1s]  failed "build cockpit.spec" at Wed Mar  2 06:23:46 UTC 2022.
[    1s]

The buildroot was: /var/tmp/build-root/standard-riscv64

I run osc -A https://api.opensuse.org checkout home:Andreas_Schwab:riscv:node/cockpit osc build in opensuse/leap with docker
What i miss?

@andreas-schwab
Copy link
Author

I guess that's the problem:

[ 1s] Could not mount /proc, is this a container with missing capabilities?

I have never used osc build inside a container. You might want to use --vm-type kvm, though that makes it more complicated to debug the build.

@luyahan
Copy link
Collaborator

luyahan commented Mar 3, 2022 •
edited
Loading

NODE_ENV=production SRCDIR=/home/abuild/rpmbuild/BUILD/cockpit-251.3 ./tools/webpack-make -d dist/kdump/Makefile.deps -c ./webpack.config.js

I enter sandbox and run node -v

abuild@2726c9381c7f:/home/abuild/rpmbuild/BUILD/cockpit-251.3> node -v
v17.5.0

The version is v17.5.0.
And v17.5.0 node is not merge fix patch

@luyahan
Copy link
Collaborator

luyahan commented Mar 3, 2022

I have already added that patch, it doesn't make a difference.

https://build.opensuse.org/package/view_file/home:Andreas_Schwab:riscv:node/nodejs18/riscv.patch

May be you should merge patch into https://build.opensuse.org/package/show/home:Andreas_Schwab:riscv:node/nodejs17

@andreas-schwab
Copy link
Author

Sorry, I made an error in the project settings. Please try again.

@luyahan
Copy link
Collaborator

luyahan commented Mar 4, 2022

Sorry, I made an error in the project settings. Please try again.

This cl to fix this issue:https://chromium-review.googlesource.com/c/v8/v8/+/3503170

luyahan added a commit to luyahan/nodejs-riscv64 that referenced this issue Mar 7, 2022
@luyahan
deps: V8: cherry-pick c6f6626deb14
cbf28f9 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626
@luyahan luyahan mentioned this issue Mar 7, 2022
Merged
@luyahan
Copy link
Collaborator

luyahan commented Mar 8, 2022

Build pass

@luyahan luyahan closed this as completed Mar 8, 2022
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Mar 10, 2022
@luyahan
deps: V8: cherry-pick c6f6626deb14
29c0522 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: #42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit to targos/node that referenced this issue Mar 17, 2022
@luyahan @targos
deps: V8: cherry-pick c6f6626deb14
5b7702f 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: nodejs#42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit to targos/node that referenced this issue Mar 17, 2022
@luyahan @targos
deps: V8: cherry-pick c6f6626deb14
3c4fbf9 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: nodejs#42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
bengl pushed a commit to nodejs/node that referenced this issue Mar 21, 2022
@luyahan @bengl
deps: V8: cherry-pick c6f6626deb14
063ff08 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: #42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@luyahan @danielleadams
deps: V8: cherry-pick c6f6626deb14
a60db31 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: nodejs#42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@luyahan @danielleadams
deps: V8: cherry-pick c6f6626deb14
d46ec6c 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: #42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@luyahan @danielleadams
deps: V8: cherry-pick c6f6626deb14
da804da 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: #42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@luyahan @danielleadams
deps: V8: cherry-pick c6f6626deb14
ba1d949 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: #42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@luyahan @xtx1130
deps: V8: cherry-pick c6f6626deb14
20190b3 
Original commit message:

    [riscv64] Fix segmentation fault of webpack-make from cockpit

    issue: riscv-collab/v8#520

    Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79376}

Refs: v8/v8@c6f6626

PR-URL: nodejs#42240
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
kangwoosukeq pushed a commit to prosyslab/v8 that referenced this issue Apr 28, 2022
@luyahan @kangwoosukeq
[riscv64] Fix segmentation fault of webpack-make from cockpit
ae6ae5f 
issue: riscv-collab#520

Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
Reviewed-by: Yahan Lu <yahan@iscas.ac.cn>
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#79376}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreas-schwab @luyahan