Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticSearch Sink to use sink_decouple by default #17073

Closed
Tracked by #17095
kwannoel opened this issue Jun 3, 2024 · 3 comments
Closed
Tracked by #17095

ElasticSearch Sink to use sink_decouple by default #17073

kwannoel opened this issue Jun 3, 2024 · 3 comments

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Jun 3, 2024

So it can isolate sink job failure.

@github-actions github-actions bot added this to the release-1.10 milestone Jun 3, 2024
@kwannoel
Copy link
Contributor Author

kwannoel commented Jun 3, 2024

Generalizing this further, which sink should have sink_decouple set and which should not? What's the criteria? cc @hzxa21 @xxhZs

From our docs it seems like some support sink_decouple, and others do not. Why don't we enable it for all sinks that support sink_decouple?

https://docs.risingwave.com/docs/current/data-delivery/#sink-decoupling

Copy link
Contributor

github-actions bot commented Aug 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@xxchan
Copy link
Member

xxchan commented Sep 30, 2024

#17095

@xxchan xxchan closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants