Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update librdkafka to v2.3.0 #15313

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Feb 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

to fix #15235

Changelog

https://github.com/confluentinc/librdkafka/releases/tag/v2.3.0

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Runji Wang <wangrunji0408@163.com>
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: What I confirmed is apply the patch of confluentinc/librdkafka#4460 can resolve the hang problem of rust-rdkafka. We need to examine whether v2.3.0 can work again. cc @shanicky

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to upgrade this to main. But I have concerns that cherry-picking this to 1.7 might introduce side-effects and we don't have large enough time window to test thoroughly. IMO the most serious way should be only cherry-picking the fix PR of the dependency and use patched version. But I know it's more troublesome than simply upgrading.

Just want to mention this risk. I'm fine to proceed in whatever way.

@wangrunji0408
Copy link
Contributor Author

Please have a quick review on the upstream changelog.

Especially for this section, to make sure there will be no side-effect on us:

Upgrade considerations

retry.backoff.ms:
If it is set greater than retry.backoff.max.ms which has the default value of 1000 ms then it is assumes the value of retry.backoff.max.ms.
To change this behaviour make sure that retry.backoff.ms is always less than retry.backoff.max.ms.
If equal then the backoff will be linear instead of exponential.

topic.metadata.refresh.fast.interval.ms:
If it is set greater than retry.backoff.max.ms which has the default value of 1000 ms then it is assumes the value of retry.backoff.max.ms.
To change this behaviour make sure that topic.metadata.refresh.fast.interval.ms is always less than retry.backoff.max.ms.
If equal then the backoff will be linear instead of exponential.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 11d49b4 Feb 29, 2024
32 of 33 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/bump-librdkafka branch February 29, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta node hang DDL processing when connection setup timeout of SASL connection
4 participants