fix(subscription): fix drop subscription not clear cursor #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
changed the title
xxhZs
force-pushed
the
xxh/fix-cursor-drop-subscription
branch
from
b25d898 to
0c98e65
Compare
xxhZs
changed the title
hzxa21
reviewed
Jun 25, 2024
| .catalog_writer()? | ||
| .list_change_log_epochs(table_id, seek_timestamp, 2) | ||
| .list_change_log_epochs(table_id.table_id(), seek_timestamp, 2) |
There was a problem hiding this comment.
I have several questions related to list_change_log_epochs:
- Why do we put
list_change_log_epochsincatalog_writer? It is a read-only operation. - Why do we have
list_change_log_epochsin SessionImpl but unused? - What will
list_change_log_epochsreturn if the requested table_id is dropped? Should changelist_change_log_epochsto make it return an error when the table_id is not found to handle the case when subscription is dropped instead of adding a new method to check existence of a subscription?
| if let Cursor::Subscription(cursor) = v { | ||
| !matches!(cursor.state, State::Invalid) | ||
| } else { | ||
| true |
There was a problem hiding this comment.
I wonder whether we have similar issue for query cursor. I suspect that query cursor also suffer from the same issue of being valid after the table is dropped.
hzxa21
approved these changes
Jul 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The current behavior is that after deleting the sub, the cursor will still consume cached data, but the next pull will report an error
invalid cursors will be deleted when creating a new cursor
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.