Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support batch read s3 parquet file #17673

Merged
merged 15 commits into from
Jul 18, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jul 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Example

-- function signature file_scan(file_format, storage_type, s3_region, s3_access_key, s3_secret_key, file_location)
select * from file_scan(
  'parquet',
  's3',
  'ap-southeast-2',
  'xxxxxxxxxx',
  'yyyyyyyy',
  's3://your-bucket/path/to/fila_name.parquet'
);

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Jul 16, 2024
@chenzl25 chenzl25 requested a review from fuyufjh July 18, 2024 09:25
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/batch/src/executor/s3_file_scan.rs Outdated Show resolved Hide resolved
src/frontend/src/scheduler/plan_fragmenter.rs Show resolved Hide resolved
@chenzl25 chenzl25 enabled auto-merge July 18, 2024 14:50
@chenzl25 chenzl25 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 2e1d910 Jul 18, 2024
31 of 32 checks passed
@chenzl25 chenzl25 deleted the dylan/support_batch_read_s3_parquet_file branch July 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants