Follow xsoar guidelines #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve code by replacing return_output for return_results, as well as adding client class
It fixes the problem with the mirroring feature. It also adds the mapping file of the integration to map all fields required for the mirroring feature.
It also adds tests to the commands implemented.
figarrido
force-pushed
the
follow-xsoar-guidelines
branch
from
ef56fe9
to
a36a23f
Compare
DNRRomero
pushed a commit
that referenced
this pull request
Nov 8, 2024
…emisto#35310) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #1/19 (demisto#35234) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #9/19 (demisto#35242) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #8/19 (demisto#35241) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #7/19 (demisto#35240) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #4/19 (demisto#35237) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #11/19 (demisto#35244) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #19/19 (demisto#35252) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #3/19 (demisto#35236) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #10/19 (demisto#35243) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #12/19 (demisto#35245) Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * Updated docker image to demisto/python3:3.10.14.100715. PR batch #13/19 (demisto#35246) Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * Updated docker image to demisto/python3:3.10.14.100715. PR batch #14/19 (demisto#35247) Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * Updated docker image to demisto/python3:3.10.14.100715. PR batch #17/19 (demisto#35250) Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * demisto/python3:3.10.14.100715 | 0-100 | PR batch #15/19 (demisto#35248) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #15/19 * Fix text encoding * Update Pulsedive.yml --------- Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * demisto/python3:3.10.14.100715 | 0-100 | PR batch #16/19 (demisto#35249) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #16/19 * Update ThousandEyes.yml --------- Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * demisto/python3:3.10.14.100715 | 0-100 | PR batch #2/19 (demisto#35235) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #2/19 * pre-commit fixes * fix --------- Co-authored-by: iapt@paloaltonetworks.com <iapt@paloaltonetworks.com> * demisto/python3:3.10.14.100715 | 0-100 | PR batch #6/19 (demisto#35239) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #6/19 * Empty commit * fixes * fix * space * fix --------- Co-authored-by: iapt@paloaltonetworks.com <iapt@paloaltonetworks.com> * demisto/python3:3.10.14.100715 | 0-100 | PR batch #5/19 (demisto#35238) * Updated docker image to demisto/python3:3.10.14.100715. PR batch #5/19 * fixes * Empty commit * Empty commit * Empty commit * Empty commit --------- Co-authored-by: iapt@paloaltonetworks.com <iapt@paloaltonetworks.com> Co-authored-by: inbalapt1 <164751454+inbalapt1@users.noreply.github.com> * Updated docker image to demisto/python3:3.10.14.100715. PR batch #18/19 (demisto#35251) Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> * Update RN * Empty commit to re-trigger build pipeline --------- Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com> Co-authored-by: iapt@paloaltonetworks.com <iapt@paloaltonetworks.com> Co-authored-by: inbalapt1 <164751454+inbalapt1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have