Skip to content

Commit

Permalink
return keep going when a state machine has changed its state
Browse files Browse the repository at this point in the history
previously, when an animation advanced by 0 seconds, it would return true, which was interpreted as meaning that the animation needed to keep advancing.
We changed that behavior and now a linear animation will return false if it didn't advance.
A side effect of that is that now the animation state that calls advance, sets keepGoing to false instead of true.
So the animation wouldn't keep going in that frame.
Which is ok as long as we add a new condition to identify whether the state machine layer should keep going in the next frame based on whether it changed its state internally.
This PR adds that condition

Diffs=
51c3bbcde2 return keep going when a state machine has changed its state (#8564)
  • Loading branch information
bodymovin committed Nov 15, 2024
1 parent 087e7f4 commit 891de52
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f34822a1249d46f46e6ca60daa6ea3f3045f3981
51c3bbcde2dbd0c07d63ca2d1569f53aba668c23
2 changes: 1 addition & 1 deletion wasm/submodules/rive-runtime

0 comments on commit 891de52

Please sign in to comment.