From 993834c1b97fd9208d7cb39d160848442eca8620 Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Sun, 3 Oct 2021 21:14:55 -0700 Subject: [PATCH] Revert "[Object manager] fix comments" This reverts commit 56debfc0633d75827331b273df9110a7bab46110. --- python/ray/tests/test_object_manager.py | 2 ++ src/ray/common/ray_config_def.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/python/ray/tests/test_object_manager.py b/python/ray/tests/test_object_manager.py index 98ed9ef9708e0..38ff6ff3c3d1a 100644 --- a/python/ray/tests/test_object_manager.py +++ b/python/ray/tests/test_object_manager.py @@ -296,6 +296,8 @@ def driver(): ray.get(driver.remote()) +# TODO(ekl) this sometimes takes much longer (10+s) due to a higher level +# pull retry. We should try to resolve these hangs in the chunk transfer logic. def test_pull_bundles_admission_control(shutdown_only): cluster = Cluster() object_size = int(6e6) diff --git a/src/ray/common/ray_config_def.h b/src/ray/common/ray_config_def.h index 54411b7892cbe..418828a2dc916 100644 --- a/src/ray/common/ray_config_def.h +++ b/src/ray/common/ray_config_def.h @@ -183,7 +183,8 @@ RAY_CONFIG(int64_t, worker_register_timeout_seconds, 30) RAY_CONFIG(int64_t, redis_db_connect_retries, 50) RAY_CONFIG(int64_t, redis_db_connect_wait_milliseconds, 100) -/// The object manager's global timer interval in milliseconds. +/// Timeout, in milliseconds, to wait before retrying a failed pull in the +/// ObjectManager. RAY_CONFIG(int, object_manager_timer_freq_ms, 100) /// Timeout, in milliseconds, to wait before retrying a failed pull in the